i18n(ja): fix mdsvgicon tag scrambled as wrapper in release-notes-2023.md - #23653
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Japanese 2023 release notes update three entries. The changes replace lowercase inline SVG tags with capitalized ChangesRelease note updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change corrects malformed icon markup in the Japanese release notes without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…3.md The Japanese translation wrapped trailing prose as child content of the self-closing <MDSvgIcon /> component (an MT-scramble artifact), unlike its normal self-closing usage elsewhere in the corpus and in the English source. Restructures 4 occurrences so <MDSvgIcon /> stays self-closing with the location text as plain sentence content.
0b36d53 to
22de146
Compare
[LGTM Timeline notifier]Timeline:
|
Summary
In
tidb-cloud/releases/release-notes-2023.md, the Japanese translation wrapped trailing descriptive prose as child content of<mdsvgicon>(e.g.<mdsvgicon name="...">左下隅にあります。</mdsvgicon>), unlike the component's normal self-closing usage (<MDSvgIcon name="..." />) everywhere else in the corpus and in the English source. This is an MT-scramble artifact.<MDSvgIcon />stays self-closing, matching the English source and established usage elsewhere (e.g.manage-user-access.md).mdsvgicon→MDSvgIcon) and removed a stray>HTML entity in one of the fixed lines, matching the plain>convention used for breadcrumb-style menu paths elsewhere in the corpus.Found while reviewing an unrelated PR in the same file; out of scope there, so filed separately.
Test plan
upstream/release-8.5)<MDSvgIcon />self-closing convention against sibling files (e.g.manage-user-access.md,configure-maintenance-window.md)npx markdownlint-cli2on the changed file: 0 issuesSummary by CodeRabbit