Skip to content

i18n(ja): fix mdsvgicon tag scrambled as wrapper in release-notes-2023.md - #23653

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-mdsvgicon-scramble-release-notes-2023
Aug 28, 2026
Merged

i18n(ja): fix mdsvgicon tag scrambled as wrapper in release-notes-2023.md#23653
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-mdsvgicon-scramble-release-notes-2023

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

In tidb-cloud/releases/release-notes-2023.md, the Japanese translation wrapped trailing descriptive prose as child content of <mdsvgicon> (e.g. <mdsvgicon name="...">左下隅にあります。</mdsvgicon>), unlike the component's normal self-closing usage (<MDSvgIcon name="..." />) everywhere else in the corpus and in the English source. This is an MT-scramble artifact.

  • Fixes 4 occurrences (lines ~315, ~389-390, ~854) so <MDSvgIcon /> stays self-closing, matching the English source and established usage elsewhere (e.g. manage-user-access.md).
  • Also normalized casing (mdsvgiconMDSvgIcon) and removed a stray &gt; HTML entity in one of the fixed lines, matching the plain > convention used for breadcrumb-style menu paths elsewhere in the corpus.
  • Restructured the two adjacent bullets around line 389-390 that had nested/overlapping broken tags spanning multiple icons and sentences.

Found while reviewing an unrelated PR in the same file; out of scope there, so filed separately.

Test plan

  • Verified each fix against the English source (upstream/release-8.5)
  • Verified <MDSvgIcon /> self-closing convention against sibling files (e.g. manage-user-access.md, configure-maintenance-window.md)
  • npx markdownlint-cli2 on the changed file: 0 issues
  • Reviewer check for natural JA phrasing

Summary by CodeRabbit

  • Documentation
    • Updated Japanese release notes for July 25, July 4, and February 22, 2023.
    • Improved wording and formatting in entries covering support, navigation, and console audit logs.
    • Corrected inline icon references to ensure they render consistently in the release notes.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 9 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6a2f8538-ed12-4935-b47d-97905a9701cc

📥 Commits

Reviewing files that changed from the base of the PR and between 0b36d53 and 22de146.

📒 Files selected for processing (1)
  • tidb-cloud/releases/release-notes-2023.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9eda156a-7822-4527-b666-7a7586a5e14a

📥 Commits

Reviewing files that changed from the base of the PR and between a349332 and 0b36d53.

📒 Files selected for processing (1)
  • tidb-cloud/releases/release-notes-2023.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Japanese 2023 release notes update three entries. The changes replace lowercase inline SVG tags with capitalized MDSvgIcon components and revise related menu and support wording.

Changes

Release note updates

Layer / File(s) Summary
Update release note component references and wording
tidb-cloud/releases/release-notes-2023.md
The support, navigation, and console audit log entries use capitalized MDSvgIcon tags and revised Japanese wording.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0b36d

The change corrects malformed icon markup in the Japanese release notes without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the changes and test results, but it omits the required statement of which TiDB version(s) the changes apply to. Add the affected TiDB version selection, such as master or the applicable release branch, using the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese localization change and the malformed mdsvgicon usage in the release-notes file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…3.md

The Japanese translation wrapped trailing prose as child content of the
self-closing <MDSvgIcon /> component (an MT-scramble artifact), unlike
its normal self-closing usage elsewhere in the corpus and in the English
source. Restructures 4 occurrences so <MDSvgIcon /> stays self-closing
with the location text as plain sentence content.
@yahonda
yahonda force-pushed the fix-mdsvgicon-scramble-release-notes-2023 branch from 0b36d53 to 22de146 Compare August 28, 2026 06:01
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 28, 2026
@qiancai
qiancai merged commit 5ea3f2c into pingcap:i18n-ja-release-8.5 Aug 28, 2026
5 of 9 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-28 08:23:29.493720304 +0000 UTC m=+835644.664814447: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants