Skip to content

i18n(ja): fix mdsvgicon tag scrambled as wrapper across 4 files - #23654

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-mdsvgicon-scramble-batch2
Aug 28, 2026
Merged

i18n(ja): fix mdsvgicon tag scrambled as wrapper across 4 files#23654
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-mdsvgicon-scramble-batch2

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Same MT-scramble defect as #23653, found via a corpus-wide sweep for the remaining occurrences: the self-closing <MDSvgIcon name="..." /> component was scrambled into a wrapper tag (<mdsvgicon name="...">...unrelated trailing prose...</mdsvgicon>), instead of matching its self-closing usage in the English source and elsewhere in the corpus.

Fixes 7 occurrences:

  • tidb-cloud/data-service-manage-data-app.md (1)
  • tidb-cloud/oauth2.md (1)
  • tidb-cloud/tidb-cloud-password-authentication.md (3, identical pattern)
  • tidb-cloud/use-chat2query-api.md (1)

Verified each fix against the English source (upstream/release-8.5) and the <MDSvgIcon /> self-closing convention used in sibling files. markdownlint-cli2 clean on all touched files.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected interface icons and button labels in TiDB Cloud instructions.
    • Clarified steps for creating Data Apps and viewing authorized OAuth apps.
    • Improved Japanese instructions for signing out, changing passwords, and managing MFA.
    • Updated Chat2Query Data App creation guidance for clearer navigation.

Same MT-scramble defect as pingcap#23653: the self-closing
<MDSvgIcon /> component was scrambled into a wrapper tag holding
unrelated trailing prose as fake child content, instead of matching
its self-closing usage in the English source and elsewhere in the
corpus. Fixes 7 occurrences in data-service-manage-data-app.md,
oauth2.md, tidb-cloud-password-authentication.md (x3), and
use-chat2query-api.md.
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 77d377b8-4b8f-4970-ac37-e78fac8391bf

📥 Commits

Reviewing files that changed from the base of the PR and between a349332 and 068350c.

📒 Files selected for processing (4)
  • tidb-cloud/data-service-manage-data-app.md
  • tidb-cloud/oauth2.md
  • tidb-cloud/tidb-cloud-password-authentication.md
  • tidb-cloud/use-chat2query-api.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The documentation updates replace malformed lowercase icon markup with self-closing MDSvgIcon components. They also correct click instructions and Japanese sentence structure for account settings actions.

Changes

Documentation icon corrections

Layer / File(s) Summary
Correct icon markup and instructions
tidb-cloud/data-service-manage-data-app.md, tidb-cloud/use-chat2query-api.md, tidb-cloud/oauth2.md, tidb-cloud/tidb-cloud-password-authentication.md
Data app and account settings steps now use correctly formatted MDSvgIcon components. The instructions include explicit click actions and corrected Japanese phrasing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 06835

This change corrects malformed documentation component tags in four Japanese documentation files without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix to malformed mdsvgicon wrapper tags across four files.
Description check ✅ Passed The description explains the seven fixes, lists all affected files, identifies the target version, provides a related reference, and records AI involvement. The required sections are complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 28, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2026
@qiancai
qiancai merged commit 0650f7d into pingcap:i18n-ja-release-8.5 Aug 28, 2026
5 of 9 checks passed
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-28 08:23:53.602253405 +0000 UTC m=+835668.773347526: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants