i18n(ja): fix noun-smashed word order for Support-prefixed bullets - #23651
i18n(ja): fix noun-smashed word order for Support-prefixed bullets#23651yahonda wants to merge 2 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (28)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThis PR corrects Japanese wording across historical release notes and documentation. It also revises TiDB Cloud release-note entries and supporting documentation without changing documented functionality, links, issue references, or experimental labels. ChangesDocumentation wording normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only corrects Japanese release-note wording and terminology across the affected files; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description provides a detailed change summary, affected version, related PR reference, AI involvement, and applicable change-type checkboxes. It covers the required information and matches the changeset. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (28 skipped: 28 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
66cbe5b to
10fed73
Compare
10fed73 to
ccddc75
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a094d90e-67b7-4b61-81c9-89cafb28f372
📒 Files selected for processing (28)
releases/release-1.0-ga.mdreleases/release-2.0-ga.mdreleases/release-2.0-rc.4.mdreleases/release-2.1-rc.1.mdreleases/release-2.1.3.mdreleases/release-2.1.9.mdreleases/release-3.0-beta.mdreleases/release-3.0-ga.mdreleases/release-3.0.0-beta.1.mdreleases/release-3.0.0-rc.1.mdreleases/release-3.0.0-rc.2.mdreleases/release-3.0.4.mdreleases/release-4.0.0-beta.mdreleases/release-4.0.3.mdreleases/release-6.0.0-dmr.mdreleases/release-6.1.0.mdreleases/release-6.5.0.mdreleases/release-6.5.8.mdreleases/release-6.6.0.mdreleases/release-7.0.0.mdreleases/release-7.1.4.mdreleases/release-7.5.1.mdreleases/release-pre-ga.mdreleases/release-rc.4.mdsync-diff-inspector/sync-diff-inspector-overview.mdtidb-cloud/releases/release-notes-2021.mdtidb-cloud/releases/release-notes-2022.mdtiup/tiup-component-dm.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
Corpus-wide sweep of release-note bullets translated from EN's verb-initial 'Support X' pattern. JA had consistently reordered these into a bare noun compound with no particle (a prefix-glued 'サポートX'), rather than a proper clause. Reworded each site to match its own list's established local convention (mostly 'Xをサポート', a few 'Xのサポート' where local siblings already used that noun-ending form). Also fixed a handful of related mid-sentence 'Support X to do Y' scrambles found in passing in the same files. Excludes releases/release-6.0.0-dmr.md (already fixed in pingcap#23650) and 2 confirmed false positives (a genuine 'support ticket'/'support entries' noun usage, not this verb pattern).
ccddc75 to
dbdc07b
Compare
…support-noun-smashing-wording # Conflicts: # releases/release-3.0.0-rc.2.md
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
What is changed, added or deleted? (Required)
EN release notes frequently open a bullet with an imperative "Support X" (matching sibling "Add X"/"Fix X" bullets). JA has consistently mistranslated this by keeping EN's word order literally, gluing サポート onto the front of X with no particle, producing an ungrammatical noun compound rather than a clause.
Reworded each site to match its own list's established local convention — verified per-site against the corresponding English text:
Xをサポート(verb form), matching the dominant convention confirmed in sibling bullets across many files.release-3.0-beta.md's summary/highlight section):Xのサポート(noun form), matching that specific list's own already-correct sibling bullets — later unified to verb form for full within-file consistency.Also fixed several related mid-sentence "Support X to do Y" word-order scrambles found in passing in the same files (e.g.
release-3.0-ga.md's "ALTER algorithmINPLACE/INSTANT" line had the two literal values swapped and reordered;release-3.0.4.mdwas missing a sentence break after a backtick-quoted variable name), plus a few adjacent link-text/wording/terminology fixes found during review (e.g. converting verb-clause link text to noun phrases to avoid an awkward "ことをサポート", "放送テーブル"→"ブロードキャストテーブル" mistranslation).28 files changed, 55 sites converted. Includes the single site originally fixed in #23650 (now closed as consolidated into this PR). Excludes 2 confirmed false positives found during verification (
tidb-cloud-support.md's "Support tickets" andrelease-notes-2023.md's "support entries" — both genuine noun usages of "support", not this verb pattern; the latter's own separate wording issue is fixed in #23652).Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit