Skip to content

i18n(ja): fix dropped particle before Support-verb bullets - #23655

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-particle-before-support-verb
Aug 28, 2026
Merged

i18n(ja): fix dropped particle before Support-verb bullets#23655
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-particle-before-support-verb

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up to #23650/#23651 (which fixed "Support X" bullets translated as a noun-smashed compound). Found a related, distinct manifestation while searching for more instances: EN "Support the X" release-note bullets where the を particle was dropped immediately before サポートする (e.g. 構文サポートする instead of 構文をサポートする), across 10 old release notes (release-2.1 through release-5.0).

Verified each site individually against upstream/release-8.5 before fixing.

9 files changed, 11 sites converted.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese grammar and wording across multiple historical release notes.
    • Clarified descriptions of supported SQL syntax, functions, collations, variables, and Follower Read functionality.
    • Updated terminology for MAX_EXECUTION_TIME, ALTER DATABASE, SHOW CREATE DATABASE IF NOT EXISTS, partition regions, init_connect, and related entries.
    • No functional or behavioral changes were made.

EN 'Support the X' release-note bullets had their を particle dropped before サポートする (e.g. サポートする instead of をサポートする), a distinct but related manifestation of the noun-smashing pattern fixed in pingcap#23650/pingcap#23651. Found via a corpus-wide scan for a bracket/backtick/kanji immediately followed by サポート with no particle.
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5fef7135-f1c1-47f9-9461-9562ad6cbac2

📥 Commits

Reviewing files that changed from the base of the PR and between 0959b29 and c79532b.

📒 Files selected for processing (9)
  • releases/release-2.1-rc.1.md
  • releases/release-2.1.10.md
  • releases/release-3.0-beta.md
  • releases/release-3.1.0-beta.md
  • releases/release-4.0-ga.md
  • releases/release-4.0.11.md
  • releases/release-4.0.14.md
  • releases/release-4.0.6.md
  • releases/release-5.0.4.md

📝 Walkthrough

Walkthrough

This change corrects Japanese grammar in nine release note entries across TiDB release documentation. It adds the particle or adjusts wording without changing documented technical content or behavior.

Changes

Release note wording

Layer / File(s) Summary
Japanese grammar corrections
releases/release-2.1-rc.1.md, releases/release-2.1.10.md, releases/release-3.0-beta.md, releases/release-3.1.0-beta.md, releases/release-4.0-ga.md, releases/release-4.0.11.md, releases/release-4.0.14.md, releases/release-4.0.6.md, releases/release-5.0.4.md
Corrects Japanese wording in syntax, feature, variable, collation, and function support entries. The TiDB 3.1.0 Beta notes reword two Follower Read entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 63669

This PR makes localized Japanese translation corrections in historical release notes without changing product behavior, so no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese localization change: fixing omitted particles before support-verb bullets.
Description check ✅ Passed The description explains the motivation, scope, affected files and sites, target branch, related issues, AI involvement, and applicable change categories. It satisfies the required template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (9 skipped: 9 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Aug 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2026
@yahonda
yahonda marked this pull request as ready for review August 28, 2026 06:23
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 28, 2026
…dropped-particle-before-support-verb

# Conflicts:
#	releases/release-4.0.6.md
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@qiancai
qiancai merged commit d48a6b8 into pingcap:i18n-ja-release-8.5 Aug 28, 2026
3 of 8 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-28 08:24:11.393987703 +0000 UTC m=+835686.565081824: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants