i18n(ja): fix particle/punctuation trapped inside bold spans - #23641
i18n(ja): fix particle/punctuation trapped inside bold spans#23641yahonda wants to merge 2 commits into
Conversation
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/M
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis documentation-only change corrects Japanese Markdown emphasis, punctuation, spacing, grammar, and wording across TiDB, DM, TiCDC, dashboard, and TiDB Cloud pages. Documented functionality and requirements remain unchanged. ChangesDocumentation formatting corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The PR only adjusts Japanese Markdown emphasis boundaries, but three changed lines still contain localized text or punctuation defects: an extra space, a stray colon, and omitted particles. These are bounded documentation correctness issues, so the PR is mergeable with explicit owner awareness or follow-up. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
416403d to
0f09f8b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 21c911c5-7763-4d93-a3d9-eda3f1ee005a
📒 Files selected for processing (24)
best-practices/pd-scheduling-best-practices.mdcolumn-privilege-management.mddashboard/dashboard-key-visualizer.mddashboard/dashboard-ops-reverse-proxy.mddevelop/dev-guide-create-table.mddevelop/dev-guide-sample-application-ruby-rails.mddevelop/dev-guide-transaction-restraints.mddevelop/dev-guide-update-data.mddm/dm-safe-mode.mddm/relay-log.mdfilter-dml-event.mdfunctions-and-operators/sequence-functions.mdgrafana-tikv-dashboard.mdsystem-variables.mdticdc/ticdc-architecture.mdticdc/troubleshoot-ticdc.mdtidb-cloud/changefeed-sink-to-mysql.mdtidb-cloud/configure-external-storage-access.mdtidb-cloud/essential-changefeed-overview.mdtidb-cloud/essential-changefeed-sink-to-kafka.mdtidb-cloud/essential-changefeed-sink-to-mysql.mdtidb-cloud/integrate-tidbcloud-with-airbyte.mdtidb-cloud/releases/release-notes-2024.mdtidb-cloud/top-ru.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
0f09f8b to
a5335f9
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
develop/dev-guide-create-table.md (1)
97-97: 🎯 Functional Correctness | 🟡 MinorRemove the remaining leading colon.
Line 97 still renders
:before[日時]. The change removes bold formatting from the colon but does not remove the colon.Committable replacement
-- :[日時](/data-type-date-and-time.md)型は、時間値を格納できます。 +- [日時](/data-type-date-and-time.md)型は、時間値を格納できます。As per path instructions: Markdown findings must include an exact committable suggestion when the fix is contiguous.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c7aa0af1-f96d-4a87-8e34-fbc98e2b367e
📒 Files selected for processing (3)
best-practices/pd-scheduling-best-practices.mddashboard/dashboard-ops-reverse-proxy.mddevelop/dev-guide-create-table.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
a5335f9 to
154c7f9
Compare
Found via a corpus-wide scan for bold spans (**...**) whose content
starts with a Japanese comma, period, or particle character (、/。/は),
where EN's own bold boundary excludes it (e.g. "This section provides
a detailed description of these key metrics on the
**TiKV-Details** dashboard" bolds only the product name, not a
preceding comma).
24 files, 27 sites. Most fixes move the leading punctuation/particle
outside the bold span, preserving content; a few sites needed a
larger fix where the bold content had been reduced to just a bare
punctuation mark with the actual emphasized word missing or
misplaced nearby (e.g. a duplicated closing period, or three
separately-bolded numbers collapsed into one bold span with the
commas trapped inside) — each was reconstructed to match the
corresponding EN sentence's own bold boundaries exactly.
Also fixes, found while reviewing the already-touched files:
- a dropped を particle in best-practices/pd-scheduling-best-practices.md:
`evict-slow-store-scheduler`有効にする → を有効にする.
- the mirror defect (a trailing が particle trapped INSIDE the
closing ** instead of outside) at all 3 occurrences of an identical
sentence in dashboard/dashboard-ops-reverse-proxy.md, matching EN's
own bold boundary ("only in this path" is bolded, not the subject
"services").
- a dropped は particle in develop/dev-guide-create-table.md, twice:
once after `_tidb_rowid`, and once after a [primary key constraint]
link, where the missing は made the sentence read as if "constraint"
were duplicated instead of distinguishing the constraint (subject)
from the constrained columns (object).
154c7f9 to
1d5b489
Compare
- develop/dev-guide-create-table.md: remove a stray leading colon before the datetime link, inconsistent with the bullet's own established phrasing. - filter-dml-event.md: restore missing が and に particles. - tidb-cloud/essential-changefeed-sink-to-mysql.md: remove an extra space after a comma.
qiancai
added
translation/no-need
2 participants
What is changed, added or deleted? (Required)
Found via a corpus-wide scan for bold spans (
**...**) whose content starts with a Japanese comma, period, or particle character (、/。/は), where EN's own bold boundary excludes it — e.g. EN "This section provides a detailed description of these key metrics on the TiKV-Details dashboard" bolds only the product name, not a preceding comma, while the JA rendering hadこのセクションでは**、TiKV-Details**ダッシュボード(comma trapped inside).24 files, 27 sites. Most fixes move the leading punctuation/particle outside the bold span, preserving content. A few sites needed a larger fix where the bold content had been reduced to just a bare punctuation mark with the actual emphasized word missing or misplaced nearby:
tidb-cloud/essential-changefeed-overview.md,essential-changefeed-sink-to-kafka.md,essential-changefeed-sink-to-mysql.md: EN bolds the?character itself (click **?**); JA had lost the bold on?and left a duplicated trailing period instead.tidb-cloud/top-ru.md: EN separately bolds three numbers (**5**, **20**, and **100**); JA had collapsed them into one bold span with commas trapped inside, plus an unrelated extra bold on "instance" that EN doesn't bold at all.tidb-cloud/configure-external-storage-access.md: a trailingの(possessive particle) was trapped inside the closing**of an S3 permission name.develop/dev-guide-update-data.md: a triple-asterisk (bold+italic) span wrapping a leading comma, where EN has no emphasis at all at that position — removed the formatting entirely to match.Each site was individually checked against its corresponding EN sentence before fixing, rather than applying one blanket "move the comma" rule (mirroring the lesson from a similar sweep on [[ja-term-target-selection]]: check every site's own exact EN text).
Verified
markdownlint-cli2clean on all touched files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
/dashboard/path.INSERT ON DUPLICATE KEY UPDATE.