i18n(ja): keep SQL transaction isolation level names in English - #23639
Conversation
|
Skipping CI for Draft Pull Request. |
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR standardizes English transaction isolation-level terminology and updates related Japanese wording in seven documentation files. It changes headings, link text, and descriptions without modifying functionality or public entities. ChangesTransaction terminology documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The PR only changes Japanese documentation, but two minor wording issues remain that could confuse readers about snapshot isolation and the displayed isolation-level value. The change is low risk and mergeable with explicit owner follow-up to correct those sentences. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.) Full details: Description checkExplanation The description covers the changes, affected version, AI involvement, and applicable checklist items. It is sufficiently complete for review, although the stated file count differs from the change summary. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
88df375 to
4b775bc
Compare
f1e0eb0 to
66556ce
Compare
Repeatable Read and Read Committed (and their literal SQL keyword forms REPEATABLE READ / READ COMMITTED) are SQL-92 standard isolation-level names, not descriptive phrases. Unifies 3 competing literal-kanji/katakana translations of Repeatable Read (繰り返し読み取り/反復可能読み取り/リピータブルリード) to the literal English term, mirroring each site's own exact EN casing (title case in prose, lowercase in the SQL-92 four-level list, all-caps for literal SQL syntax, which was already correct and untouched). Also converts the 2 sibling entries in that same four-level bullet list (read uncommitted, serializable) that were left translated while the other two entries in the identical list were being fixed, producing an inconsistent list; the trailing full stop after "serializable" mirrors EN's own list, which ends the last item with a period. Also fixes 3 directly-adjacent Read Committed occurrences that were the same defect on the same line/heading/file as a Repeatable Read fix: transaction-isolation-levels.md's "## Read Committed isolation level" heading, which the rest of that file already used consistently in body text; one shared table cell in tidb-performance-tuning-config.md; and a literal "コミット済みを読む" link text in pessimistic-transaction.md that should read "Read Committed" like its sibling "Repeatable Read" link two lines above. Other Read Committed occurrences elsewhere in the corpus are out of scope for this PR. Also removes 2 stray "SI" text fragments left before two links in transaction-isolation-levels.md, an unrelated pre-existing MT artifact on the same sentence with no counterpart in EN.
66556ce to
72cfa7b
Compare
Two bold spans in the "Note" block had a leading 、 or は trapped just inside the opening/closing ** markers, where EN's own bold boundary excludes them (e.g. "it might **break the transaction isolation level**" — bold starts at "break", not at the preceding comma).
宣伝 literally means "advertise/promote" and reads as if TiDB is exaggerating a marketing claim, which isn't the intended meaning of EN "advertises as X for compatibility with MySQL" (i.e. TiDB reports/ labels its isolation level as REPEATABLE-READ for MySQL clients). Reworded to 表示されます (a neutral "is displayed/shown as") in the 3 sites using this exact sentence (transaction-isolation-levels.md, tidb-cloud/transaction-concepts.md, system-variables.md). Also fixes the one remaining 宣伝 in the corpus, in a different but related sense (announcing a network address, not claiming a label): tikv-configuration-file.md's `advertise-addr` description used 宣伝 instead of the established アドバタイズ katakana term already used consistently across DM/PD/Kafka-related config docs for this exact networking sense of "advertise".
Both section headings ("Repeatable Read isolation level" and "Read
Committed isolation level") had been fully mirrored in English,
while every body occurrence of the same terms in this file uses the
established mixed pattern (English term + 分離レベル, e.g.
"Repeatable Read分離レベルでは..."). Unifies the 2 headings to match.
2 sites had a space between the English term and 分離レベル (Read Committed 分離レベル / Repeatable Read 分離レベル), while every other occurrence in the same file joins them directly with no space. Removed for consistency.
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6b6bf1a0-b63a-4ef7-ad1f-6591e163f5d3
📒 Files selected for processing (7)
develop/dev-guide-transaction-overview.mdpessimistic-transaction.mdsystem-variables.mdtidb-cloud/transaction-concepts.mdtidb-performance-tuning-config.mdtikv-configuration-file.mdtransaction-isolation-levels.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
- システム変数[`tidb_rc_read_check_ts`](...)使用をサポートします → の使用をサポートします (missing の) - システム変数[`tidb_rc_write_check_ts`](...)有効にすることで → を有効にすることで (missing を)
The earlier 宣伝→表示 rewording (passive "is displayed as") reads as
if TiDB itself, not its reported isolation-level value, is being
displayed as REPEATABLE-READ. EN's own sentence has this same
implicit-object structure ("TiDB advertises REPEATABLE-READ") but
the active verb "advertises" carries the intended meaning more
naturally than the JA passive construction did. Made the actual
subject of the display explicit: この変数の値 (this variable's
value) in system-variables.md, and この一貫性レベル (this
consistency level, referring back to Snapshot Isolation consistency)
in the two files sharing the "TiDB implements SI consistency, which
it advertises as REPEATABLE-READ" sentence.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Repeatable ReadandRead Committed(and their literal SQL keyword formsREPEATABLE READ/READ COMMITTED) are SQL-92 standard isolation-level names, not descriptive phrases that should be translated. This corpus renderedRepeatable Readinconsistently with 3 competing literal-kanji/katakana translations while English already dominated elsewhere.This PR unifies the remaining non-English
Repeatable Readoccurrences to the literal English term, mirroring each site's own exact EN casing rather than picking one fixed form:Repeatable Read(title case, matching most prose mentions)Repeatable ReadRepeatable Readrepeatable read(lowercase, matching the SQL-92 four-level bullet list indevelop/dev-guide-transaction-overview.md, where EN itself uses lowercase)Also converts the 2 sibling entries in that same four-level bullet list (
コミットされていない読み取り→read uncommitted,シリアル化可能→serializable) that were left translated while the other two entries in the identical list were being fixed, producing an inconsistent list — the trailing full stop afterserializablemirrors EN's own list, which ends the last item with a period.Also unifies the section headings ("Repeatable Read isolation level" / "Read Committed isolation level") to match the mixed English-term + 分離レベル pattern already used consistently in every body occurrence of these terms in the same file, rather than mirroring EN's fully-English heading text — and removes 2 stray extra spaces before 分離レベル for the same consistency.
6 files, ~20 sites.
Also fixes, found along the way:
Read Committedoccurrences that were the same defect on the same line/heading/file as aRepeatable Readfix:transaction-isolation-levels.md's## Read Committed isolation levelheading (before being unified per above), which the rest of that file already used consistently in body text; one shared table cell intidb-performance-tuning-config.md; and a literalコミット済みを読むlink text inpessimistic-transaction.mdthat should readRead Committedlike its siblingRepeatable Readlink two lines above.transaction-isolation-levels.mdwith no counterpart in EN, the same defect class fixed corpus-wide in i18n(ja): fix stray text fragments and scrambled link lists #23640/i18n(ja): fix particle/punctuation trapped inside bold spans #23641: two "SI" fragments and a "1番目の" (lit. "the first") fragment before an unrelated paper citation link.transaction-isolation-levels.md, part of the same corpus-wide sweep as i18n(ja): fix particle/punctuation trapped inside bold spans #23641.REPEATABLE-READcompatibility label — 宣伝 reads as if TiDB were making a marketing claim, not a neutral technical report of its isolation-level name. Also fixed the one remaining 宣伝 in the corpus, intikv-configuration-file.md'sadvertise-addrdescription, to match the establishedアドバタイズkatakana term already used consistently for that networking sense of "advertise" across DM/PD/Kafka config docs.Other
Read Committedoccurrences elsewhere in the corpus (system-variables.md, several release notes) are the same defect class but out of scope for this PR — left for a follow-up sweep.スナップショット分離("Snapshot Isolation") was also checked and found already consistent (17 occurrences, dominant, well-formed) — not part of this PR.Independently re-reviewed the full diff and did a structural 1:1 comparison of
transaction-isolation-levels.mdagainst the EN source (line count, heading position, and anchors all match exactly) before marking ready for review.Verified
markdownlint-cli2clean on all touched files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
REPEATABLE-READare displayed.advertise-addrconfiguration description.