Skip to content

i18n(ja): keep SQL transaction isolation level names in English - #23639

Merged
qiancai merged 8 commits into
i18n-ja-release-8.5from
fix-repeatable-read-term-english
Aug 28, 2026
Merged

i18n(ja): keep SQL transaction isolation level names in English#23639
qiancai merged 8 commits into
i18n-ja-release-8.5from
fix-repeatable-read-term-english

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Repeatable Read and Read Committed (and their literal SQL keyword forms REPEATABLE READ / READ COMMITTED) are SQL-92 standard isolation-level names, not descriptive phrases that should be translated. This corpus rendered Repeatable Read inconsistently with 3 competing literal-kanji/katakana translations while English already dominated elsewhere.

This PR unifies the remaining non-English Repeatable Read occurrences to the literal English term, mirroring each site's own exact EN casing rather than picking one fixed form:

  • 繰り返し読み取り → Repeatable Read (title case, matching most prose mentions)
  • 反復可能読み取り → Repeatable Read
  • リピータブルリード → Repeatable Read
  • one occurrence → repeatable read (lowercase, matching the SQL-92 four-level bullet list in develop/dev-guide-transaction-overview.md, where EN itself uses lowercase)

Also converts the 2 sibling entries in that same four-level bullet list (コミットされていない読み取りread uncommitted, シリアル化可能serializable) that were left translated while the other two entries in the identical list were being fixed, producing an inconsistent list — the trailing full stop after serializable mirrors EN's own list, which ends the last item with a period.

Also unifies the section headings ("Repeatable Read isolation level" / "Read Committed isolation level") to match the mixed English-term + 分離レベル pattern already used consistently in every body occurrence of these terms in the same file, rather than mirroring EN's fully-English heading text — and removes 2 stray extra spaces before 分離レベル for the same consistency.

6 files, ~20 sites.

Also fixes, found along the way:

  • 3 directly-adjacent Read Committed occurrences that were the same defect on the same line/heading/file as a Repeatable Read fix: transaction-isolation-levels.md's ## Read Committed isolation level heading (before being unified per above), which the rest of that file already used consistently in body text; one shared table cell in tidb-performance-tuning-config.md; and a literal コミット済みを読む link text in pessimistic-transaction.md that should read Read Committed like its sibling Repeatable Read link two lines above.
  • 3 stray text fragments left before links in transaction-isolation-levels.md with no counterpart in EN, the same defect class fixed corpus-wide in i18n(ja): fix stray text fragments and scrambled link lists #23640/i18n(ja): fix particle/punctuation trapped inside bold spans #23641: two "SI" fragments and a "1番目の" (lit. "the first") fragment before an unrelated paper citation link.
  • 2 particle/punctuation-trapped-in-bold defects in transaction-isolation-levels.md, part of the same corpus-wide sweep as i18n(ja): fix particle/punctuation trapped inside bold spans #23641.
  • Reworded 宣伝 ("advertise" in the exaggerated/promotional sense) to 表示されます (neutral "is displayed as") in the 3 sites describing TiDB's REPEATABLE-READ compatibility label — 宣伝 reads as if TiDB were making a marketing claim, not a neutral technical report of its isolation-level name. Also fixed the one remaining 宣伝 in the corpus, in tikv-configuration-file.md's advertise-addr description, to match the established アドバタイズ katakana term already used consistently for that networking sense of "advertise" across DM/PD/Kafka config docs.

Other Read Committed occurrences elsewhere in the corpus (system-variables.md, several release notes) are the same defect class but out of scope for this PR — left for a follow-up sweep. スナップショット分離 ("Snapshot Isolation") was also checked and found already consistent (17 occurrences, dominant, well-formed) — not part of this PR.

Independently re-reviewed the full diff and did a structural 1:1 comparison of transaction-isolation-levels.md against the EN source (line count, heading position, and anchors all match exactly) before marking ready for review.

Verified markdownlint-cli2 clean on all touched files.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Standardized Japanese transaction documentation to use the official English names for SQL isolation levels.
    • Clarified wording describing how snapshot isolation and REPEATABLE-READ are displayed.
    • Updated related configuration and system variable references for consistent terminology.
    • Improved the Japanese wording for the advertise-addr configuration description.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 9 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1ceef130-195e-4f64-8eb2-de9efa306f3f

📥 Commits

Reviewing files that changed from the base of the PR and between 08b3bd6 and 201f912.

📒 Files selected for processing (3)
  • system-variables.md
  • tidb-cloud/transaction-concepts.md
  • transaction-isolation-levels.md
📝 Walkthrough

Walkthrough

The PR standardizes English transaction isolation-level terminology and updates related Japanese wording in seven documentation files. It changes headings, link text, and descriptions without modifying functionality or public entities.

Changes

Transaction terminology documentation

Layer / File(s) Summary
Standardize transaction terminology
develop/dev-guide-transaction-overview.md, pessimistic-transaction.md, transaction-isolation-levels.md, system-variables.md, tidb-cloud/transaction-concepts.md, tidb-performance-tuning-config.md, tikv-configuration-file.md
Isolation-level names and comparison links now use English terms such as Repeatable Read and Read Committed. Related Japanese wording now uses “表示されます” and “アドバタイズする”.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🔵 Low · up to 08b3b

The PR only changes Japanese documentation, but two minor wording issues remain that could confuse readers about snapshot isolation and the displayed isolation-level value. The change is low risk and mergeable with explicit owner follow-up to correct those sentences.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: keeping SQL transaction isolation-level names in English for Japanese internationalization.
Description check ✅ Passed The description covers the changes, affected version, AI involvement, and applicable checklist items. It is sufficiently complete for review, although the stated file count differs from the change sum…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

Full details: Description check

Explanation

The description covers the changes, affected version, AI involvement, and applicable checklist items. It is sufficiently complete for review, although the stated file count differs from the change summary.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-repeatable-read-term-english

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. area/develop This PR relates to the area of TiDB App development. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2026
@yahonda
yahonda force-pushed the fix-repeatable-read-term-english branch from 88df375 to 4b775bc Compare August 28, 2026 00:17
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2026
@yahonda
yahonda force-pushed the fix-repeatable-read-term-english branch 2 times, most recently from f1e0eb0 to 66556ce Compare August 28, 2026 00:31
@yahonda yahonda changed the title i18n(ja): keep Repeatable Read isolation level name in English i18n(ja): keep SQL transaction isolation level names in English Aug 28, 2026
Repeatable Read and Read Committed (and their literal SQL keyword
forms REPEATABLE READ / READ COMMITTED) are SQL-92 standard
isolation-level names, not descriptive phrases. Unifies 3 competing
literal-kanji/katakana translations of Repeatable Read
(繰り返し読み取り/反復可能読み取り/リピータブルリード) to the literal
English term, mirroring each site's own exact EN casing (title case
in prose, lowercase in the SQL-92 four-level list, all-caps for
literal SQL syntax, which was already correct and untouched).

Also converts the 2 sibling entries in that same four-level bullet
list (read uncommitted, serializable) that were left translated while
the other two entries in the identical list were being fixed,
producing an inconsistent list; the trailing full stop after
"serializable" mirrors EN's own list, which ends the last item with a
period.

Also fixes 3 directly-adjacent Read Committed occurrences that were
the same defect on the same line/heading/file as a Repeatable Read
fix: transaction-isolation-levels.md's "## Read Committed isolation
level" heading, which the rest of that file already used consistently
in body text; one shared table cell in
tidb-performance-tuning-config.md; and a literal "コミット済みを読む"
link text in pessimistic-transaction.md that should read "Read
Committed" like its sibling "Repeatable Read" link two lines above.
Other Read Committed occurrences elsewhere in the corpus are out of
scope for this PR.

Also removes 2 stray "SI" text fragments left before two links in
transaction-isolation-levels.md, an unrelated pre-existing MT
artifact on the same sentence with no counterpart in EN.
Two bold spans in the "Note" block had a leading 、 or は trapped
just inside the opening/closing ** markers, where EN's own bold
boundary excludes them (e.g. "it might **break the transaction
isolation level**" — bold starts at "break", not at the preceding
comma).
宣伝 literally means "advertise/promote" and reads as if TiDB is
exaggerating a marketing claim, which isn't the intended meaning of
EN "advertises as X for compatibility with MySQL" (i.e. TiDB reports/
labels its isolation level as REPEATABLE-READ for MySQL clients).
Reworded to 表示されます (a neutral "is displayed/shown as") in the
3 sites using this exact sentence (transaction-isolation-levels.md,
tidb-cloud/transaction-concepts.md, system-variables.md).

Also fixes the one remaining 宣伝 in the corpus, in a different but
related sense (announcing a network address, not claiming a label):
tikv-configuration-file.md's `advertise-addr` description used 宣伝
instead of the established アドバタイズ katakana term already used
consistently across DM/PD/Kafka-related config docs for this exact
networking sense of "advertise".
Both section headings ("Repeatable Read isolation level" and "Read
Committed isolation level") had been fully mirrored in English,
while every body occurrence of the same terms in this file uses the
established mixed pattern (English term + 分離レベル, e.g.
"Repeatable Read分離レベルでは..."). Unifies the 2 headings to match.
2 sites had a space between the English term and 分離レベル
(Read Committed 分離レベル / Repeatable Read 分離レベル), while
every other occurrence in the same file joins them directly with no
space. Removed for consistency.
Found on independent review: "1番目の" before the [A Critique of
ANSI SQL Isolation Levels] link has no counterpart in EN ("According
to the standard described in the [...] paper"), the same defect
class fixed corpus-wide in #23640/#23641.
@yahonda
yahonda marked this pull request as ready for review August 28, 2026 02:02
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6b6bf1a0-b63a-4ef7-ad1f-6591e163f5d3

📥 Commits

Reviewing files that changed from the base of the PR and between a349332 and 08b3bd6.

📒 Files selected for processing (7)
  • develop/dev-guide-transaction-overview.md
  • pessimistic-transaction.md
  • system-variables.md
  • tidb-cloud/transaction-concepts.md
  • tidb-performance-tuning-config.md
  • tikv-configuration-file.md
  • transaction-isolation-levels.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

Comment thread system-variables.md Outdated
Comment thread transaction-isolation-levels.md Outdated
- システム変数[`tidb_rc_read_check_ts`](...)使用をサポートします
  → の使用をサポートします (missing の)
- システム変数[`tidb_rc_write_check_ts`](...)有効にすることで
  → を有効にすることで (missing を)
The earlier 宣伝→表示 rewording (passive "is displayed as") reads as
if TiDB itself, not its reported isolation-level value, is being
displayed as REPEATABLE-READ. EN's own sentence has this same
implicit-object structure ("TiDB advertises REPEATABLE-READ") but
the active verb "advertises" carries the intended meaning more
naturally than the JA passive construction did. Made the actual
subject of the display explicit: この変数の値 (this variable's
value) in system-variables.md, and この一貫性レベル (this
consistency level, referring back to Snapshot Isolation consistency)
in the two files sharing the "TiDB implements SI consistency, which
it advertises as REPEATABLE-READ" sentence.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
yahonda added a commit to yahonda/docs that referenced this pull request Aug 28, 2026
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 28, 2026
@qiancai
qiancai merged commit aa5a03d into i18n-ja-release-8.5 Aug 28, 2026
5 of 9 checks passed
@qiancai
qiancai deleted the fix-repeatable-read-term-english branch August 28, 2026 08:21
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-28 08:21:38.736465979 +0000 UTC m=+835533.907560114: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants