Skip to content

i18n(ja): unify remaining Read Committed isolation level notation - #23649

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-read-committed-terminology
Aug 28, 2026
Merged

i18n(ja): unify remaining Read Committed isolation level notation#23649
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-read-committed-terminology

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Follow-up to #23639 (which unified the Repeatable Read isolation level term and part of the Read Committed backlog). This PR converts the remaining Japanese-only / inconsistently-cased renderings of the SQL standard "Read Committed" isolation level to English, verified per-site against the corresponding English text and mirroring each site's own EN casing (e.g. Title Case "Read Committed" vs lowercase-hyphenated "read-committed", depending on how EN itself renders it at that specific site).

Also fixed one same-paragraph self-contradiction found in passing in releases/release-6.3.0.md: a bullet heading already correctly said "Read-Committed" while the very next line's body prose still said the katakana form.

Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md — both already fixed by the still-open #23639 on an unmerged branch; touching them here would conflict.

5 files changed, 6 sites converted.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Standardized Read Committed and read-committed terminology across transaction isolation, system variable, and release documentation.
    • Clarified descriptions of Read Committed behavior, TSO-related features, and TiCDC’s default isolation level.
    • Improved wording and link labels while preserving existing documentation links, version availability, and documented configuration scopes.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 17e1a0d7-4308-4db4-84e4-ff7532645b43

📥 Commits

Reviewing files that changed from the base of the PR and between a349332 and f360274.

📒 Files selected for processing (5)
  • basic-features.md
  • releases/release-2.0.6.md
  • releases/release-6.0.0-dmr.md
  • releases/release-6.3.0.md
  • system-variables.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The PR standardizes Read Committed terminology across transaction isolation documentation, system-variable descriptions, and release notes. It also refines wording for TSO-fetch behavior and corrects one Japanese phrase without changing links or configuration semantics.

Changes

Read Committed documentation terminology

Layer / File(s) Summary
Reference terminology updates
basic-features.md, system-variables.md
Transaction isolation labels and system-variable descriptions use consistent Read Committed terminology. Existing links and configuration semantics remain unchanged.

Release note terminology updates

Layer / File(s) Summary
Release note terminology updates
releases/release-2.0.6.md, releases/release-6.0.0-dmr.md, releases/release-6.3.0.md
Release notes use consistent Read Committed wording and refine TSO-fetch descriptions. Documented behavior and issue references remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to f3602

This PR standardizes Read Committed terminology in Japanese documentation without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: qiancai, invalid-email-address

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese internationalization change and the unification of remaining Read Committed isolation-level terminology.
Description check ✅ Passed The description explains the changes, affected documentation version, related PR, AI involvement, and applicable checklist items. It is complete and directly related to the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2026
@yahonda
yahonda force-pushed the fix-read-committed-terminology branch 7 times, most recently from 20d6705 to 6aabc1f Compare August 28, 2026 05:01
Follow-up to PR pingcap#23639: converts remaining Japanese-only and inconsistent-casing renderings of the SQL standard Read Committed isolation level to English, mirroring each site's own EN casing (Title Case, lowercase-hyphenated, etc). Deliberately excludes transaction-isolation-levels.md and tidb-performance-tuning-config.md, which PR pingcap#23639 already fixed on an unmerged branch.
@yahonda
yahonda force-pushed the fix-read-committed-terminology branch from 6aabc1f to f360274 Compare August 28, 2026 05:09
@yahonda
yahonda marked this pull request as ready for review August 28, 2026 05:11
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 28, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-28 08:22:35.045341419 +0000 UTC m=+835590.216435565: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 0959b29 into pingcap:i18n-ja-release-8.5 Aug 28, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants