Repository navigation
🧰 skill: release: the author path check follows the template skill's round 1 again - #428
Merged
Merged
Conversation
The author path of the v0.25.0 release failed with "Change a command omits the spec, manifest, or scenario step". Since #406, Change a command in the template's AGENTS.md has no numbered steps: it sends the author to the rounds of the nicely-extension skill. The check read an empty list. When Change a command has no numbered steps, the check now replays round 1 of the skill: the intake, spec.md, then the first scenario with a handler that does no work. Change a command must still declare the command in the manifest and the catalog before that scenario. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last check of the v0.25.0 release,
author-path.sh, failed: "Change a command omits the spec, manifest, or scenario step". The release itself is fine. Since #406, "Change a command" in the template'sAGENTS.mdhas no numbered steps and sends the author to the rounds of thenicely-extensionskill. The script still looked for numbered steps there and found none.When "Change a command" has no numbered steps, the script now replays "Round 1" of the rendered skill instead: the intake (nothing to record for the probe), then
spec.md, then the first scenario with a handler that does no work. "Change a command" must still say that the command is declared in the manifest and the catalog before that scenario, so a drift in that text still fails. Older numbered texts keep their path.Proof:
author-path.sh v0.25.0failed before the change and passes after ("PASS scenario fails for the missing greeting", "PASS v0.25.0").just checkpasses, and so do shellcheck and shfmt.Outside the plan: a fix to a release check, found during the v0.25.0 release.
author-path.sh v0.25.0passesjust checkpassesnclychanges. The release script ran against the published tagjust signoffpassed on ad40ebbReviewed with codex-loop: 1 round with gpt-6-astra. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.