Skip to content

🧰 skill: release: the author path rewrites the acceptance case of COR-104-T5 - #441

Open
pascalandy wants to merge 2 commits into
mainfrom
fix/author-path-acceptance
Open

pascalandy wants to merge 2 commits into
mainfrom
fix/author-path-acceptance

Conversation

@pascalandy

Copy link
Copy Markdown
Owner

Outside the plan: step 11 of release-nicely for v0.26.0 failed on a stale step of the author path, as #428 did for v0.25.0.

Problem

author-path.sh v0.26.0 exits 1 with one finding:

author-path: FAIL #323 #324: unsupported Remove the example step: 1. Delete `inspect.go`, `worker/inspect.py`, and `testdata/script/inspect.txtar`. Rewrite `testdata/script/refusal.txtar` for a refusal of your command, or delete it when the command has none. Rewrite `testdata/script/acceptance.txtar` for a property of your command

COR-104-T5 (62c0cbe) added the last sentence to step 1 of "Remove the example" in the template's AGENTS.md. The script knew only the two older forms of that step.

Change

  1. Refactor: fct_remove_example moves from author-path-command.sh to author-path-remove.sh, which author-path.sh sources. author-path-command.sh was over the 2500-token limit of just limits with the fix. No behavior changes: at 6087634 the script fails with the same finding.
  2. Fix: step 1 accepts the new form. It deletes the files of the example as before, then writes testdata/script/acceptance.txtar with an acceptance case of the greeting. That case reads the message key of the answer with the answer reader, compares it with message: "ready", and requires the bad answer "pending" to fail.

Evidence

On om1, against the published tag v0.26.0:

  • at 6087634 (refactor only): exit 1, the same unsupported Remove the example step finding
  • at 477de7e (head): exit 0, author-path: PASS v0.26.0

Against v0.25.0, the head fails later, in the Change a command step (spec.md:99: the ID greeting repeats the one of line 91). This pull request does not touch that step. The script follows the template of the newest tag.

Checklist

  • 1. Spec: n/a, no command, flag, JSON key, or error code changes
  • 2. Scenario: the failing proof is author-path.sh v0.26.0 at 6087634
  • 3. Code: author-path.sh v0.26.0 passes at the head
  • 4. Text: n/a, no user-facing string
  • 5. Checks: just check passes
  • 6. Verify: n/a, a release script, proven against the published tag above
  • 7. Docs: n/a, the steps of release-nicely do not change
  • 8. Sign off: just signoff passes

by Opus-5.5 via Claude Code

pascalandy and others added 2 commits November 3, 2026 10:00
…ath to its own file

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e template of COR-104-T5 asks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 21ee7289-5893-4a90-97c5-9be5e954426b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@pascalandy

Copy link
Copy Markdown
Owner Author

Step 11 of release-nicely for v0.27.0 hits the same finding. On om1, author-path.sh v0.27.0 against the published tag exited 1:

author-path: short-module exit 1
author-path: FAIL #323 #324: unsupported Remove the example step: 1. Delete `inspect.go`, `worker/inspect.py`, and `testdata/script/inspect.txtar`. Rewrite `testdata/script/refusal.txtar` for a refusal of your command, or delete it when the command has none. Rewrite `testdata/script/acceptance.txtar` for a property of your command
author-path: PASS scenario fails for the missing greeting
author-path: scenario-green exit 0
author-path: FAIL 1 findings for v0.27.0

v0.27.0 changes only Markdown since v0.26.1, so this is the stale script, not the template. Every other step passed: release-verify (assets and the Homebrew tap), brew-qa.sh and extension-qa.sh on the mini. Until this PR merges, each release fails step 11 on this one finding.

by Opus-5.5 via Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant