Repository navigation
abi/kern/userlib: Use usize-like Addr in even more places - #2708
Draft
jamesmunns wants to merge 8 commits into
Draft
jamesmunns wants to merge 8 commits into
jamesmunns wants to merge 8 commits into
Conversation
usize-like Addr in even more places
hawkw
approved these changes
Sep 23, 2026
hawkw
left a comment
Member
There was a problem hiding this comment.
yeah okay that's a a bunch of stuff, but i think this is good!
Contributor
Author
|
In case you wondered, "will this make humility mad?" The answer is yes, undoubtedly: jamesmunns@lurch ~ $ pfexec ./humility0623 -a /staff/jamesmunns/sidecar-b-abi.zip -t sidecar-sp tasks
humility: WARNING: archive on command-line overriding archive in environment file
humility: attached to 0483:374e:0028001E4741500720383733 via ST-Link V3
system time = 57185
ID TASK GEN PRI STATE
0 jefe 0 0 recv, notif: fault timer(T+15)
humility tasks failed: loading reflected value of type humility_doppel::TaskDesc
Caused by:
not a base type: Tuple(Tuple("Addr", [Base(U32(134790657))])) |
jamesmunns
marked this pull request as draft
September 29, 2026 15:48
This was referenced Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2703, @hawkw (reasonably) asked "Why is X not also an
Addr". The answer is "wow it touched a lot more stuff", but I think is still the right choice.So: I have made this a PR to the other PR to make the concrete diff of the new-new changes easier to review.
These changes should be treated with great suspicion, they are extremely load bearing.