abi/kern/userlib: Use usize-like data for addr+len - #2703
Open
jamesmunns wants to merge 7 commits into
Open
jamesmunns wants to merge 7 commits into
jamesmunns wants to merge 7 commits into
Conversation
This abstracts over pointer size differences on different targets.
This was referenced Sep 20, 2026
Contributor
Author
|
For reviewers, I've added some "big picture" notes in #2706 on how this PR fits into the bigger picture. |
hawkw
reviewed
Sep 22, 2026
Comment on lines
+217
to
+220
| // This is icky! However, kipc uses `ssmarshal` for serialization, which | ||
| // makes the serialization of addresses a kipc binary concern, and we | ||
| // don't want to use `usize` as our wire format as serde treats that | ||
| // as a u64 in all cases, and we've always serialized addresses as u32s. |
Collaborator
There was a problem hiding this comment.
We could always switch to hubpack! Last time I tried, there was a noticeable size regression, but that was literally years ago.
Contributor
Author
hawkw
reviewed
Sep 22, 2026
hawkw
reviewed
Sep 22, 2026
hawkw
reviewed
Sep 22, 2026
| /// requirements for this; it must meet them. (For example, on ARMv7-M, it | ||
| /// must be naturally aligned for the size.) | ||
| pub base: u32, | ||
| pub base: usize, |
hawkw
reviewed
Sep 22, 2026
| // | ||
| // It's possible in the future we want `RegionDesc` to be arch-specific, but for | ||
| // now ensure that all 32-bit targets share the same ABI qualities. | ||
| #[cfg(target_pointer_width = "32")] |
Member
There was a problem hiding this comment.
i wonder if perhaps all of this ought to just be in the arch module?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series to be able to potentially run the kernel and tasks on a 64-bit host for testing purposes.
This PR switches some things in abi/kern/userlib to use
usizeinstead ofu32. On 32-bit targets, this is not a functional change, and in the first commit (before changing the types), I added some static asserts, which continue passing after the first change.