Remove GitHub ruleset from enhancement-proposals repo - #238
Merged
minmzzhang merged 1 commit intoSep 29, 2026
Merged
minmzzhang merged 1 commit into
minmzzhang merged 1 commit into
Conversation
Drop the native GitHub required_status_checks (check-human-reviews, pre-commit) and ruleset_bypass_team_ids from the enhancement-proposals repository module. Set required_approvals to null since Prow plugins now handle approval via OWNERS files (lgtm/approved labels) instead of native GitHub reviews. This aligns enhancement-proposals with the Prow/Tide merge automation pattern already used by the osac mono-repo. AI-Assisted-By: Chai Bot (osac_public persona) Signed-off-by: Chai Bot <chai-bot@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Comment |
eliorerz
approved these changes
Sep 29, 2026
minmzzhang
approved these changes
Sep 29, 2026
minmzzhang
pushed a commit
that referenced
this pull request
Sep 29, 2026
) Restores the `required_status_checks` and `ruleset_bypass_team_ids` for the `enhancement-proposals` repository that were removed in PR #238. PR #238 correctly set `required_approvals` from `2` to `null` (letting Prow handle approvals via labels), but also removed the CI status checks. Per reviewer feedback, the status checks should remain as hard gates. ## Changes - Restores `required_status_checks` with `check-human-reviews` and `pre-commit` - Restores `ruleset_bypass_team_ids` for `wg-infra` - `required_approvals` stays at `null` (from PR #238) ## Net effect from original config The only difference from the original configuration is `required_approvals: 2 → null`. All other settings are restored to their original values. --- *AI-generated. Review for accuracy.* @minmzzhang requested in [Slack thread](https://redhat-internal.slack.com/archives/C0B8KR3HK16/p1790608924340709) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary - Restores `check-human-reviews` and `pre-commit` as required status checks for `enhancement-proposals`, each with integration ID `15368`. - Restores the `wg-infra` team’s ruleset bypass. - Keeps `required_approvals = null`. ## Affected areas - **Repository configuration:** Updates GitHub ruleset settings in `repositories.tf`. - **CI and access control:** Requires the two checks and allows `wg-infra` to bypass the ruleset. - **API, controllers, database, tests, and documentation:** No changes reported. - **Backward compatibility:** No API or data compatibility change is reported. The merge rules change: both checks must pass for merges unless the ruleset is bypassed. Tests are not reported. ## Risk classification No `risk:ship`, `risk:show`, or `risk:ask` label can be substantiated. The supplied context and repository search do not provide classification criteria or an applied label. The evidence is insufficient to identify a nearby classification or explain why it did not qualify. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Chai Bot <chai-bot@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the native GitHub
required_status_checks(check-human-reviews,pre-commit) andruleset_bypass_team_idsfrom theenhancement-proposalsrepository module. Setrequired_approvalstonullsince Prow plugins handle approval via OWNERS files (lgtm/approvedlabels) instead of native GitHub reviews.This aligns
enhancement-proposalswith the Prow/Tide merge automation pattern already used by theosacmono-repo.Context
The
enhancement-proposalsrepo had a GitHub branch protection ruleset requiring 2 native GitHub "Approve" reviews, which conflicted with the Prow-based approval workflow. PRs with all required Prow labels (lgtm,approved,jira/valid-reference) and green CI were blocked because Prow's/lgtmadds a label but does not submit a native GitHub approval review.Per team decision,
enhancement-proposalsshould be managed solely by Prow — no merge queue and no GitHub ruleset.Changes
required_approvals:2→null(Prow labels handle approvals)required_status_checks: removed (check-human-reviews,pre-commit)ruleset_bypass_team_ids: removed (no ruleset to bypass)Basic branch protection is preserved (linear history, no force push, PRs required).
AI-generated. Review for accuracy.
@minmzzhang requested in Slack thread