NO ISSUE: Restore required status checks for enhancement-proposals - #239
Conversation
…ement-proposals PR osac-project#238 removed the GitHub ruleset configuration from the enhancement-proposals module. This restores the required status checks (check-human-reviews and pre-commit) and the wg-infra bypass so that the branch protection rules are enforced again. AI-Assisted-By: Claude (Anthropic) Signed-off-by: Chai Bot <chai-bot@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review. WalkthroughThe ChangesRepository ruleset
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The required checks and intended team bypass are restored without changing the approval requirement. The configured check names match the workflows, and no PR-introduced merge blocker is evident. 🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
Full details: Ai-AttributionExplanation AI use is explicit in the PR description and in the commit trailer
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
Restores the
required_status_checksandruleset_bypass_team_idsfor theenhancement-proposalsrepository that were removed in PR #238.PR #238 correctly set
required_approvalsfrom2tonull(letting Prow handle approvals via labels), but also removed the CI status checks. Per reviewer feedback, the status checks should remain as hard gates.Changes
required_status_checkswithcheck-human-reviewsandpre-commitruleset_bypass_team_idsforwg-infrarequired_approvalsstays atnull(from PR Remove GitHub ruleset from enhancement-proposals repo #238)Net effect from original config
The only difference from the original configuration is
required_approvals: 2 → null. All other settings are restored to their original values.AI-generated. Review for accuracy.
@minmzzhang requested in Slack thread
Summary
check-human-reviewsandpre-commitas required status checks forenhancement-proposals, each with integration ID15368.wg-infrateam’s ruleset bypass.required_approvals = null.Affected areas
repositories.tf.wg-infrato bypass the ruleset.Tests are not reported.
Risk classification
No
risk:ship,risk:show, orrisk:asklabel can be substantiated. The supplied context and repository search do not provide classification criteria or an applied label. The evidence is insufficient to identify a nearby classification or explain why it did not qualify.