Skip to content

NO ISSUE: Restore required status checks for enhancement-proposals - #239

Merged
minmzzhang merged 1 commit into
osac-project:mainfrom
redhat-chai-bot:restore-enhancement-proposals-checks
Sep 29, 2026
Merged

minmzzhang merged 1 commit into
osac-project:mainfrom
redhat-chai-bot:restore-enhancement-proposals-checks

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Restores the required_status_checks and ruleset_bypass_team_ids for the enhancement-proposals repository that were removed in PR #238.

PR #238 correctly set required_approvals from 2 to null (letting Prow handle approvals via labels), but also removed the CI status checks. Per reviewer feedback, the status checks should remain as hard gates.

Changes

Net effect from original config

The only difference from the original configuration is required_approvals: 2 → null. All other settings are restored to their original values.


AI-generated. Review for accuracy.

@minmzzhang requested in Slack thread

Summary

  • Restores check-human-reviews and pre-commit as required status checks for enhancement-proposals, each with integration ID 15368.
  • Restores the wg-infra team’s ruleset bypass.
  • Keeps required_approvals = null.

Affected areas

  • Repository configuration: Updates GitHub ruleset settings in repositories.tf.
  • CI and access control: Requires the two checks and allows wg-infra to bypass the ruleset.
  • API, controllers, database, tests, and documentation: No changes reported.
  • Backward compatibility: No API or data compatibility change is reported. The merge rules change: both checks must pass for merges unless the ruleset is bypassed.

Tests are not reported.

Risk classification

No risk:ship, risk:show, or risk:ask label can be substantiated. The supplied context and repository search do not provide classification criteria or an applied label. The evidence is insufficient to identify a nearby classification or explain why it did not qualify.

…ement-proposals

PR osac-project#238 removed the GitHub ruleset configuration from the
enhancement-proposals module. This restores the required status checks
(check-human-reviews and pre-commit) and the wg-infra bypass so that
the branch protection rules are enforced again.

AI-Assisted-By: Claude (Anthropic)
Signed-off-by: Chai Bot <chai-bot@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 810b8e8a-870b-4761-adff-2fe33b131617

📥 Commits

Reviewing files that changed from the base of the PR and between c4b748c and be34dc9.

📒 Files selected for processing (1)
  • repositories.tf

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.


Walkthrough

The repo_enhancement_proposals ruleset now requires two status checks and allows the wg-infra team to bypass the ruleset. required_approvals remains unchanged.

Changes

Repository ruleset

Layer / File(s) Summary
Required checks and bypass
repositories.tf
The ruleset requires check-human-reviews and pre-commit, both with integration ID 15368. It adds wg-infra to the bypass list. required_approvals remains null.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested labels: risk:ask

Suggested reviewers: eliorerz

Merge Risk: ⚪ Minimal · up to be34d

The required checks and intended team bypass are restored without changing the approval requirement. The configured check names match the workflows, and no PR-introduced merge blocker is evident.

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning AI use is explicit in the PR description and in the commit trailer AI-Assisted-By: Claude (Anthropic). The reviewed commit does not contain an accepted Assisted-by or Generated-by trailer. It al… Replace AI-Assisted-By: Claude (Anthropic) with an accepted Assisted-by: Claude (Anthropic) or Generated-by: Claude (Anthropic) trailer, then amend the commit.
✅ Passed checks (10 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The pull request changes only repositories.tf. The added lines define status-check names, integration ID 15368, comments, and a Terraform team ID reference. They contain no API keys, tokens, passw…
No-Weak-Crypto ✅ Passed The pull request changes only repositories.tf, adding GitHub required status checks and a ruleset bypass team for repo_enhancement_proposals. The diff contains no MD5, SHA1, DES, RC4, 3DES, Blowfi…
No-Injection-Vectors ✅ Passed The pull request changes only Terraform configuration in repositories.tf. The added values are static status-check contexts, a numeric integration ID, and a static wg-infra team reference. The dif…
Container-Privileges ✅ Passed The pull request changes only repositories.tf. It adds GitHub repository ruleset settings for required status checks and the wg-infra bypass team. It does not add or modify a container or Kubernet…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only Terraform configuration in repositories.tf. The added lines define required GitHub status checks and a team bypass list; they add no logging, output, or handling of pas…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring required status checks for the enhancement-proposals repository. It does not mention the restored wg-infra bypass, but the title do…
Full details: Ai-Attribution

Explanation

AI use is explicit in the PR description and in the commit trailer AI-Assisted-By: Claude (Anthropic). The reviewed commit does not contain an accepted Assisted-by or Generated-by trailer. It also does not use Co-Authored-By, but the required attribution is still missing.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@minmzzhang

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@minmzzhang minmzzhang changed the title Restore required status checks for enhancement-proposals NO ISSUE: Restore required status checks for enhancement-proposals Sep 29, 2026
@minmzzhang
minmzzhang merged commit 19f6137 into osac-project:main Sep 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants