Skip to content

feat: support React 18.3.1 and React 19 - #24

Open
esitarz wants to merge 3 commits into
ordercloud-api:mainfrom
esitarz:feat/react-18-19-support
Open

esitarz wants to merge 3 commits into
ordercloud-api:mainfrom
esitarz:feat/react-18-19-support

Conversation

@esitarz

@esitarz esitarz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Peer react and react-dom at ^18.3.1 || ^19.0.0, with @hookform/resolvers at ^3.3.4 || ^5.7.1
  • Keep OpenID Connect login from main, and keep the JavaScript SDK peer at ^11.1.0 || ^12.0.0
  • Add the React 18/19 CI matrix, Vitest coverage, and a packed-consumer check
  • Add the issue and pull request templates from chore: Adds issue templates and updates dev toolchain #21

Stacks on #23. This branch contains that commit until #23 merges. Replaces #18 and #22, which targeted development and predate OpenID Connect.

Test plan

  • npm test (includes OpenID Connect login redirect)
  • npm run lint
  • npm run build against ordercloud-javascript-sdk@12.0.0 and React 19.2.8
  • Consumer install and build for React 18.3.1 and React 19.2.8
  • CI green
  • Merge after feat: accept ordercloud-javascript-sdk 11.1 and 12 #23 so Commitizen publishes the next version

Apps still on 11 keep installing. The README peer list matches package.json, and dependency bumps stay inside the current majors.
Keep OpenID Connect from main and the JavaScript SDK 11/12 peer range. React stays external, and both 18.3.1 and 19 install without legacy peer deps.
Bring over the forms from the August toolchain PR so bug reports and feature requests stay structured. Husky stays out because pre-commit already runs Commitizen.
@esitarz

esitarz commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author
image

this is failing as expected. It's checking for both React 18 and React 19, React 19 is succeeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant