[dop42]

Follow-up to #88, implementing the coordinator's decisions on its proposals. Item 1 (menu titles and breadcrumbs) is skipped on purpose: the header-less menu is the design the owner approved. core/*/exports.lua and the contracts are untouched. origin/main, including #89, is merged in.

Before → after

3. The X key (high priority)

• Before: the progress bar's cancel and a call's decline/hang-up were both bound to X. The host fires every mapping on a key for a single press, in no promised order, so cancelling an eat or repair during a call also ended the call.
• After: while a cancelable bar is up, it owns the press. The calls key checks the progress contract first:
  • If a cancelable bar is up and bound to the same key, the press belongs to the bar.
  • If the bar's handler already ran and the bar is gone, a cancel within the last 300 ms still counts as that press.
  • With no bar, a bar that cannot be cancelled, or the two bound to different keys by the player, X declines or hangs up as before.
• Why this resolution: moving one of the two defaults to another key would only work until a player rebinds; this rule holds for any binding. To support it, progress.State now also reports cancelable, cancelKey and cancelledAtMs.
• Tests: the two handlers are fired in both orders.

4. OPX.Refuse takes params

• Before: a refusal could not carry params, so any module whose sentence names something (a garage, an amount) followed it with NotifyLocale. The player got two toasts, and one of them still showed the {placeholder}.
• After: OPX.Refuse takes a fifth argument, params, so existing calls are unchanged. Params are limited to plain strings and numbers under plain keys, capped at 8 entries and 64 bytes per value. The client re-checks them before rendering.
• Duplicates removed: the last helper that sent both a refusal and a NotifyLocale was in the inventory; it now sends only the refusal.

2. A confirm option for menu and eye rows

• Menus: a row can carry confirm = true, or { title, yes, no }. The menu turns it into a two-row level:
  • The first row keeps things as they are, so Enter pressed without looking does nothing.
  • The second row performs the action under the same id and data, so the caller receives exactly the select it always did.
  • The shops' outfit delete, which used to build this by hand, now uses it.
• Eye: every danger row now asks for a second click, unless it sets confirm = false. Any row can opt in with confirm = true.
  • The first click relabels the row Confirm: <label> in place, inside its folder. Only a second click on the same row within 4 s runs it.
  • The staff Remove (staff vehicle) used to run on one stray click; it now asks.
  • Kick and Ban opt out, because each opens a form that confirms on its own.

5. "Where I left off" on the spawn screen

• Before: a returning character offered the spawn menu could only keep its position by picking nothing and waiting out an invisible 45-second timer.
• After:
  • When the character's row holds a position, the server says so in the offer, and the client shows a first card, Where I left off / Là où j'étais.
  • Choosing it settles the choice with no point, so the row decides where the character lands.
  • A character that has never stood anywhere does not get the card, and asking for it anyway is refused.
  • A configured place may not use the card's id.

6. Inventory give and drop

• Before: Give and Drop moved the whole stack in one click.
• After: a stack of more than one opens the existing count dialog, titled Give how many? or Drop how many? and starting at 1. Its confirm button says Give or Drop, and the dialog doubles as the confirm step. A single item still goes in one click.
• Give list: it showed #12 for each person; it now shows their character's name. The old code said "never a name"; this follows the owner's decision. The list still contains only people within arm's reach, and only the giver sees it.

7. Garage list

• Before: each row showed only a plate, e.g. 8XK2L0P.
• After: rows read Villefort Cortes · 8XK2L0P, the same label as that vehicle's key. The name derivation moved to OPX.Vehicle.DisplayName so the key and the garage list cannot drift apart.

8. Money formatting

• Before: prices showed as bare numbers or with the raw currency code: Paid 4500 at Jinguji., 2:00 1500, 500 BANK.
• After: OPX.Locale.Money(amount, type) formats every amount:
  • The thousands separator follows the language: 4,500 in English, and in French 4 500 with a narrow no-break space.
  • The currency is a catalogue word: €$, or €$ (bank) / €$ (banque).
• Where it applies: character FormatMoney, and through it every dealership price, plus shops, crafting, hauling and the paycheck.
• Bug avoided: GroupDigits reverses the string, so grouping directly with the multi-byte French separator would have reversed its bytes. Grouping happens on a one-byte placeholder that is swapped afterwards.

9. Appearance panel

• Before: Body opened a level holding one disabled row, and Outfits opened a level holding one row.
• After: both are top-level rows: the body type as a fact, and Open fitting room as the action.

10. Unused locale keys

• Removed: 26 keys, each from both languages. Each was searched for as a literal and checked for a dynamic prefix before removal:
  • calls: the incoming card and live chip, holo.tab.nearby, and the duplicated noNear / noneNear
  • target: target.hint, target.back
  • inventory: inventory.title, inventory.ui.slots
  • shops outfits.code, vehiclekeys given, garages notYours, and appearance title / command.wardrobe
• Kept: menu.key.*, because the menu contract's public Keys() still returns them.

11. No raw keys before the translations arrive

• Before: the catalogue reaches the page in parts of 250 keys per frame. On a cold join, every label not yet delivered showed as its raw key, e.g. hud.voice.state.idle.
• After:
  • The page's store marks the catalogue ready only when its last part lands. Until then, a missing key draws nothing; after that, a genuinely missing key is still shown as the key.
  • Parts are collected separately and swapped in whole, so a language change no longer blanks the live labels between parts.

Checks

• OPX_LIB_PATH=… lua tests/run.lua: 4646 checks, 0 failed (after merging main).
• New test sections cover:
  • the X key, with handlers fired in both orders
  • refusal params on the server and their rendering on the client
  • the menu confirm, end to end through the page
  • eye confirm flags
  • the appearance panel's levels
  • OPX.Locale.Money in English and French, multi-group
  • the garage model name
  • the give list's names
  • the spawn resume card, offered and refused
  • the catalogue-ready rule, read off the source because the suite has no browser
• luac -p on every Lua file, tools/check-sandbox-globals.py, and npm ci && npm run typecheck && npm run build all pass. web/index.html is rebuilt and committed.
• No new files, so the manifest and path lengths are unchanged.

Notes for review

• Eye rows registered by other resources with danger = true now confirm by default too, through the creator surface merged in Creator surface: the reads, runtime items, use handlers, a judged bar, benches, eye rows #89. That is intended. A resource that wants one click must set confirm = false.
• Character names in the give list reverse a deliberate "never a name" choice in the inventory. The comment there now records it as the owner's call.

🤖 Generated with Claude Code