Skip to content

[release-4.20] SPLAT-2867: Added support to manage kube-cloud-config for vSphere in openshift-config-managed - #521

Open
vr4manta wants to merge 6 commits into
openshift:release-4.20from
vr4manta:SPLAT-2867
Open

vr4manta wants to merge 6 commits into
openshift:release-4.20from
vr4manta:SPLAT-2867

Conversation

@vr4manta

Copy link
Copy Markdown
Contributor

SPLAT-2867

Changes

Enhanced the cluster-cloud-controller-manager-operator (CCCMO) to manage the openshift-config-managed/kube-cloud-config ConfigMap for vSphere platforms, migrating ownership from the Cluster Config Operator (CCO) to CCCMO. This enables CCCMO to:

  1. Convert INI-format cloud configs to YAML
  2. Apply transformations to add Infrastructure-derived values (vCenters, labels, networking)
  3. Maintain a single source of truth for cloud configuration
  4. Gate functionality behind the VSphereMultiVCenterDay2 feature gate

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

Since the original PRs require changes to API and library-go, we need to make sure to update the references here to point to the release-4.20 variants to make sure we do not pull in new functionality.

Also in 4.20, this operator did not support setting up feature gate accessor and did not use feature gates with transformers on providers. The commit changes for these were harvested from newer releases.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 14, 2026 •

Copy link
Copy Markdown

@vr4manta: This pull request references SPLAT-2867 which is a valid jira issue.

Details

In response to this:

SPLAT-2867

Changes

Enhanced the cluster-cloud-controller-manager-operator (CCCMO) to manage the openshift-config-managed/kube-cloud-config ConfigMap for vSphere platforms, migrating ownership from the Cluster Config Operator (CCO) to CCCMO. This enables CCCMO to:

  1. Convert INI-format cloud configs to YAML
  2. Apply transformations to add Infrastructure-derived values (vCenters, labels, networking)
  3. Maintain a single source of truth for cloud configuration
  4. Gate functionality behind the VSphereMultiVCenterDay2 feature gate

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

Since the original PRs require changes to API and library-go, we need to make sure to update the references here to point to the release-4.20 variants to make sure we do not pull in new functionality.

Also in 4.20, this operator did not support setting up feature gate accessor and did not use feature gates with transformers on providers. The commit changes for these were harvested from newer releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 48f43efa-4bae-4357-be06-1b2300970805

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mdbooth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta

Copy link
Copy Markdown
Contributor Author

/test all

@vr4manta

Copy link
Copy Markdown
Contributor Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@vr4manta vr4manta changed the title WIP: [release-4.20] SPLAT-2867: Added support to manage kube-cloud-config for vSphere in openshift-config-managed [release-4.20] SPLAT-2867: Added support to manage kube-cloud-config for vSphere in openshift-config-managed Sep 25, 2026
@vr4manta
vr4manta marked this pull request as ready for review September 25, 2026 14:21
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2026
@openshift-ci
openshift-ci Bot requested review from damdo and mdbooth September 25, 2026 14:23
@vr4manta

Copy link
Copy Markdown
Contributor Author

/retest
/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This PR was included in a payload test run from openshift/installer#10880
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-1of2
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e3cc9fe0-c0e8-11f1-94df-e062ca21626b-0

vr4manta and others added 6 commits October 6, 2026 10:29
Injecting features to allow transformers for each cloud provider
implementation so enabled feature gates can be eavaluated.

(cherry picked from commit 73b368b)
Enabling feature gate acessor to the cloud-config sync controller.

(cherry picked from commit c63ea02)
@vr4manta

vr4manta commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@vr4manta

vr4manta commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@JoelSpeed

Copy link
Copy Markdown
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 7, 2026
@vr4manta

vr4manta commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@openshift-ci

openshift-ci Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants