Drop the open action from the toolbar - #529
Merged
Merged
Conversation
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 27, 2026 20:40
35cc774 to
88dbff9
Compare
andiwand
force-pushed
the
landing/06-polish
branch
2 times, most recently
from
July 27, 2026 22:01
6d2525c to
b3bddb7
Compare
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 27, 2026 22:01
88dbff9 to
4c76a40
Compare
andiwand
force-pushed
the
landing/06-polish
branch
from
July 28, 2026 07:43
b3bddb7 to
5c5abbb
Compare
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 28, 2026 07:44
4c76a40 to
5f33efb
Compare
andiwand
force-pushed
the
landing/06-polish
branch
from
July 28, 2026 18:43
5c5abbb to
0881305
Compare
The landing screen already offers to open a document twice - the fab, and the labelled button in the empty state - and both go straight to the system picker since the chooser dialog went away. The toolbar icon was a third copy of the same intent, sitting in the one place where it is least explained: an unlabelled folder glyph next to the title. Inside a document it was the odd one out too. Every other toolbar action acts on the document that is open; this one threw it away and started over, which is what back already does, and back lands on the list where the next document is picked anyway. The tests clicked the toolbar icon to reach the picker, so they now click whichever landing entry point is on screen. Which of the two it is depends on whether an earlier test already left something in the recent list, so they match either. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RxF8q9WCwGcu5AHr9yZber
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 28, 2026 18:47
5f33efb to
0e28ba8
Compare
andiwand
marked this pull request as ready for review
July 28, 2026 18:48
andiwand
added a commit
that referenced
this pull request
Jul 28, 2026
The landing screen already offers to open a document twice - the fab, and the labelled button in the empty state - and both go straight to the system picker since the chooser dialog went away. The toolbar icon was a third copy of the same intent, sitting in the one place where it is least explained: an unlabelled folder glyph next to the title. Inside a document it was the odd one out too. Every other toolbar action acts on the document that is open; this one threw it away and started over, which is what back already does, and back lands on the list where the next document is picked anyway. The tests clicked the toolbar icon to reach the picker, so they now click whichever landing entry point is on screen. Which of the two it is depends on whether an earlier test already left something in the recent list, so they match either. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #528.
The landing screen already offers to open a document twice - the fab, and the labelled button in the empty state - and both go straight to the system picker since the chooser dialog went away. The toolbar icon was a third copy of the same intent, in the one place where it is least explained: an unlabelled folder glyph next to the title.
Inside a document it was the odd one out too. Every other toolbar action acts on the document that is open; this one threw it away and started over, which is what back already does, and back lands on the list where the next document gets picked anyway.
The instrumented tests reached the picker through that icon, so they now click whichever landing entry point is on screen - which of the two it is depends on whether an earlier test already left something in the recent list.
🤖 Generated with Claude Code