Offer the ad removal from the settings section - #530
Merged
Conversation
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 27, 2026 20:40
35cc774 to
88dbff9
Compare
andiwand
force-pushed
the
landing/08-remove-ads-in-settings
branch
from
July 27, 2026 20:40
77a20ab to
8a3a5ad
Compare
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 27, 2026 22:01
88dbff9 to
4c76a40
Compare
andiwand
force-pushed
the
landing/08-remove-ads-in-settings
branch
from
July 27, 2026 22:01
8a3a5ad to
653c0e2
Compare
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 28, 2026 07:44
4c76a40 to
5f33efb
Compare
andiwand
force-pushed
the
landing/08-remove-ads-in-settings
branch
from
July 28, 2026 07:44
653c0e2 to
d1dabe4
Compare
andiwand
force-pushed
the
landing/07-drop-open-action
branch
from
July 28, 2026 18:47
5f33efb to
0e28ba8
Compare
It was the last item in the toolbar menu on the landing screen, and with the open action gone it was the only one - a screen whose entire content is a list kept an overflow menu alive for a single row that belongs in that list. It now sits under the settings header, next to the catch-all switch, and the landing screen has no menu at all. The row is only built when there is something to sell: never in pro, where the purchase is implied, and not once it has been bought. LandingFragment asks the activity at render time rather than reading it from the state, because billing is set up by initializeProprietaryLibraries - which runs again after the play services dialog - and is not something the ViewModel could read off disk itself. That takes it out of the document view too, where the overflow menu carried it. What is left there is the snackbar that offers the purchase on entering fullscreen, which is untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RxF8q9WCwGcu5AHr9yZber
andiwand
force-pushed
the
landing/08-remove-ads-in-settings
branch
from
July 28, 2026 18:55
d1dabe4 to
974cc7f
Compare
andiwand
marked this pull request as ready for review
July 28, 2026 18:56
andiwand
added a commit
that referenced
this pull request
Jul 28, 2026
It was the last item in the toolbar menu on the landing screen, and with the open action gone it was the only one - a screen whose entire content is a list kept an overflow menu alive for a single row that belongs in that list. It now sits under the settings header, next to the catch-all switch, and the landing screen has no menu at all. The row is only built when there is something to sell: never in pro, where the purchase is implied, and not once it has been bought. LandingFragment asks the activity at render time rather than reading it from the state, because billing is set up by initializeProprietaryLibraries - which runs again after the play services dialog - and is not something the ViewModel could read off disk itself. That takes it out of the document view too, where the overflow menu carried it. What is left there is the snackbar that offers the purchase on entering fullscreen, which is untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #529.
"Remove advertisements" was the last item in the toolbar menu on the landing screen, and with the open action gone it was the only one - a screen whose entire content is a list kept an overflow menu alive for a single row that belongs in that list. It now sits under the settings header, next to the catch-all switch, and the landing screen has no menu at all.
The row is only built when there is something to sell: never in pro, where the purchase is implied, and not once it has been bought.
LandingFragmentasks the activity at render time rather than reading it from the state, because billing is set up byinitializeProprietaryLibraries- which runs again after the play services dialog - and is not something the ViewModel could read off disk itself.That takes it out of the document view too, where the overflow menu carried it. What is left there is the snackbar that offers the purchase on entering fullscreen, which is untouched.
🤖 Generated with Claude Code