Repository navigation
fix: preserve formula references across parsing and edits - #1065
Merged
Merged
Conversation
andiwand
force-pushed
the
review/46-shared-container-bounds
branch
from
October 5, 2026 14:07
3d038d9 to
6be6d26
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/47-formula-references
branch
from
October 5, 2026 14:34
e0b85f1 to
599d21f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Recognize bare whole-row ranges such as
SUM(3:5)as references, so evaluation and row edits work. Preserve the exact quoting of OOXML sheet spans when rewriting formulas, including escaped apostrophes.Ranges whose endpoints name different sheets or documents now report incomplete dependencies instead of claiming a single-sheet rectangle is complete. Check relative shifts before addition so extreme offsets produce
#REF!without signed overflow.Validation: rebuilt
odr_test; all 135 formula parser/writer/evaluator, dependency, recalculation and ODF geometry tests passed. Existing tests cover the new row-range, round-trip and shift cases; one integration test checks unresolved cross-sheet ranges and case-insensitive same-sheet endpoints.