Repository navigation
fix: bound formula arrays before dimension arithmetic - #1066
Merged
Merged
Conversation
andiwand
force-pushed
the
review/47-formula-references
branch
from
October 5, 2026 14:34
e0b85f1 to
599d21f
Compare
position_of now refuses a scan of more than the work limit of a lookup. A whole column fits, so an exact MATCH over A:A still finds its hit. The CHANGELOG entry is two lines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/48-formula-array-bounds
branch
from
October 5, 2026 14:51
152d37d to
88cb4dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Formula array-size checks multiplied dimensions in
size_t, allowing 32-bit overflow before enforcing the existing one-million-cell limit. Share one bounded, 64-bit dimension check across range expansion, array literals and broadcast results, then narrow only validated dimensions. Apply the same overflow-safe arithmetic to conditional aggregates, and reuse their four-million-cell work limit for lookups.Validation: rebuilt
odr_test; all 165 formula and recalculation tests passed, including the cached-result corpus. One regression covers a 65536-by-65536 range and the same shape produced by broadcasting, conditional aggregation over that range, and an oversized lookup. Tests ran on the local 64-bit host; no 32-bit runtime was available.