Repository navigation
fix: check text cursor and compact side-table bounds - #1064
Merged
Merged
Conversation
andiwand
force-pushed
the
review/45-number-format-bounds
branch
from
October 5, 2026 13:59
9fbaaf8 to
d7eaa56
Compare
The other tests in test/src/internal/common are named after the file they test, so the TextCursor and SortedSideTable tests move from container_bounds_test.cpp to text_cursor_test.cpp and element_registry_test.cpp. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/46-shared-container-bounds
branch
from
October 5, 2026 14:07
3d038d9 to
6be6d26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
TextCursor::advancecould violatestring_viewbounds, and consuming a NUL at EOF incorrectly advanced past the input. Check remaining length and distinguish an actual NUL byte from the end sentinel.SortedSideTablecould truncate a wide identifier when storing compact keys, breaking sorted order and subsequent lookups. Reject unrepresentable IDs before mutation.Validation: rebuilt
odr_test; 91 cursor, side-table, formula parser/writer and RTF document tests passed. Two focused helper tests cover rejection without state corruption. No new abstraction or parser-specific duplicate checks.These internal precondition fixes do not change supported document behavior.