Skip to content

test(strict-schema): cover default removal in referenced schemas #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshitethic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(strict-schema): cover default removal in referenced schemas #4808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tests/test_strict_schema_default_refs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import copy

from agents.strict_schema import ensure_strict_json_schema


def test_default_none_is_removed_from_referenced_property():
schema = {
"$defs": {
"Value": {
"type": "string",
"default": None,
}
},
"type": "object",
"properties": {
"value": {"$ref": "#/$defs/Value"},
},
}

result = ensure_strict_json_schema(copy.deepcopy(schema))

assert result["$defs"]["Value"] == {"type": "string"}
assert result["properties"]["value"] == {"$ref": "#/$defs/Value"}