test(strict-schema): cover default removal in referenced schemas - #4808
Open
harshitethic wants to merge 1 commit into
Open
test(strict-schema): cover default removal in referenced schemas#4808harshitethic wants to merge 1 commit into
harshitethic wants to merge 1 commit into
Conversation
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
Contributor
There was a problem hiding this comment.
This hits the right boundary. $defs is normalized recursively, so the default: None removal is exercised in the referenced definition while the property stays a plain $ref. Focused regression and no runtime change; I don't see an issue with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add focused regression coverage for strict-schema normalization when a
$defsschema contains adefault: Nonevalue and is referenced by a property.Why
ensure_strict_json_schema()recursively normalizes definition maps as well as referenced properties. This test locks down the existing behavior thatdefault: Noneis removed from the referenced definition while the property-level$refremains intact.This is intentionally test-only: it does not change runtime behavior.
Testing
The new test exercises the public
ensure_strict_json_schema()helper and checks both the normalized$defsentry and the preserved$ref.Related context: #4390 discusses strict-schema default handling for non-null defaults; this PR does not attempt to change that behavior.