Skip to content

Handle added and removed dynamic widget properties #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bortlesboat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle added and removed dynamic widget properties #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion chatkit/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ def full_replace_value(before_value: Any, after_value: Any) -> bool:
):
# Appends to the value prop of Markdown or Text do not trigger a full replace
continue
if full_replace_value(getattr(before, field), getattr(after, field)):
if full_replace_value(
getattr(before, field, None), getattr(after, field, None)
):
return True

return False
Expand Down
32 changes: 31 additions & 1 deletion tests/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pytest

from chatkit.server import diff_widget
from chatkit.types import WidgetItem
from chatkit.types import WidgetItem, WidgetRootUpdated
from chatkit.widgets import (
BasicRoot,
Card,
Expand Down Expand Up @@ -131,6 +131,36 @@ def test_diff(
assert diff[i].type == expected[i]


@pytest.mark.parametrize("reverse", [False, True])
@pytest.mark.parametrize(
"before, after",
[
(
{"type": "Card", "children": []},
{"type": "Card", "children": [], "size": "sm"},
),
(
{"type": "Card", "children": [{"type": "Text", "value": "Hello"}]},
{
"type": "Card",
"children": [{"type": "Text", "value": "Hello", "color": "secondary"}],
},
),
],
)
def test_diff_replaces_dynamic_widgets_when_properties_are_added_or_removed(
before: dict[str, Any], after: dict[str, Any], reverse: bool
):
before_widget = DynamicWidgetRoot.model_validate(before)
after_widget = DynamicWidgetRoot.model_validate(after)
if reverse:
before_widget, after_widget = after_widget, before_widget

assert diff_widget(before_widget, after_widget) == [
WidgetRootUpdated(widget=after_widget)
]


def test_json_dump_excludes_none_fields():
widget = Card(children=[Text(value="Hello")])

Expand Down