Repository navigation
Handle added and removed dynamic widget properties - #134
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding or removing a property in a dynamic widget template can raise
AttributeErrorduringdiff_widget(). For example, changing a card from{"type": "Card", "children": []}to the same card with"size": "sm"accessessizeon the earlier model, where it does not exist.Compare missing fields as
None, consistent with optional widget properties, so these changes emit the documented root replacement. Regression tests cover adding and removing both a rootCard.sizeproperty and a nestedText.colorproperty, and check the replacement payload.Validation with locked dependencies:
AttributeErrorbefore the fix.git diff --checkpassed.Tests ran locally on Windows without API calls. Browser rendering was not tested.