Skip to content

srd-2014 rules: add missing sections, fix Critical Hits and text errors - #995

Merged
calumbell merged 7 commits into
open5e:stagingfrom
codeGlaze:srd-2014-rules-fixes
Oct 10, 2026
Merged

calumbell merged 7 commits into
open5e:stagingfrom
codeGlaze:srd-2014-rules-fixes

Conversation

@codeGlaze

@codeGlaze codeGlaze commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Hey! I've been building an SRD reference for OrcPub and checked your srd-2014 rules
against the SRD 5.1 PDF. Most of it matches word for word. Here's what didn't.

New records follow your existing pks and fields (srd_resting_short-rest etc.).
Text comes straight from the SRD's text layer, checked against the printed pages.

Missing text (added)

  • Resting — Short Rest, Long Rest (p. 87)
  • Movement and Position — the whole combat section, Breaking Up Your Move through
    Squeezing (pp. 91–92). srd:movement-and-position already pointed at it.
  • Damage and Healing — everything after Damage Resistance: Healing, Dropping to 0 HP
    (incl. death saves), Knocking a Creature Out, Temporary HP (pp. 97–99)

Fixed

  • Critical Hits was a copy of Damage Rolls — now the actual crit rule (pp. 96–97)
  • 95 run-together words ("relyingon", "1round"), mostly Movement and Environment
  • "The old piece" → gold piece (Coins)
  • Leveling Up example: Con 18 → 17 (it then goes "from 17 to 18")
  • A few spots used PHB wording ("in chapter 1", "this chapter", Cackle Fever's
    "later in this chapter") — back to the SRD's
  • Size table: "10 b 10 ft." → "10 by 10 ft." (plus an odd apostrophe in Egyptian Deities)
  • Names: "Rnged Attacks", Darkvision labelled "Blindsight", Use an Object labelled "Search"

Tested

quicksetup + pytest pass (93), with the other PRs applied too.

Side note, not changed: the two Sage Advice quotes (Rolling 1 or 20, Bonus Actions) are
paraphrases of the Compendium rather than quotes. Might be worth a label.

Happy to split this up if it's too big.

Mostly Movement and Environment ("relyingon", "1round").
Multiclassing, Spell Range, Backgrounds, Spellcasting.
…Damage and Healing

SRD 5.1 pp. 87, 91-92, 97-99. Text from the SRD's text layer, checked against the
printed pages.
Ranged Attacks, Darkvision, Use an Object.
Also "three--- quarters" in Damage Resistance and Vulnerability.
@codeGlaze
codeGlaze force-pushed the srd-2014-rules-fixes branch from 800c4d8 to def857f Compare October 9, 2026 09:33
@codeGlaze codeGlaze changed the title SRD 5.1 rules: add the missing Resting, Movement and Position and Damage and Healing text; fix text errors srd-2014 rules: add missing sections, fix Critical Hits and text errors Oct 9, 2026
@calumbell

calumbell commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Hey @codeGlaze, these fixes are great pickups, very very helpful for us! Will try to get them reviewed and (if they look good) pushed to production this weekend. Please flag any more weirdnesses that you spot!

@codeGlaze

Copy link
Copy Markdown
Contributor Author

@calumbell 🫡 Will do! It's been so helpful to have properly extracted text to work from 😭

Happy to give a little back, let me know if anything is off.

@calumbell
calumbell merged commit 862ee34 into open5e:staging Oct 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants