Repository navigation
srd-2014 rules: add missing sections, fix Critical Hits and text errors - #995
Merged
Merged
Conversation
Mostly Movement and Environment ("relyingon", "1round").
Multiclassing, Spell Range, Backgrounds, Spellcasting.
…Damage and Healing SRD 5.1 pp. 87, 91-92, 97-99. Text from the SRD's text layer, checked against the printed pages.
Ranged Attacks, Darkvision, Use an Object.
Also "three--- quarters" in Damage Resistance and Vulnerability.
codeGlaze
force-pushed
the
srd-2014-rules-fixes
branch
from
October 9, 2026 09:33
800c4d8 to
def857f
Compare
Contributor
|
Hey @codeGlaze, these fixes are great pickups, very very helpful for us! Will try to get them reviewed and (if they look good) pushed to production this weekend. Please flag any more weirdnesses that you spot! |
Contributor
Author
|
@calumbell 🫡 Will do! It's been so helpful to have properly extracted text to work from 😭 Happy to give a little back, let me know if anything is off. |
eepMoody
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I've been building an SRD reference for OrcPub and checked your srd-2014 rules
against the SRD 5.1 PDF. Most of it matches word for word. Here's what didn't.
New records follow your existing pks and fields (
srd_resting_short-restetc.).Text comes straight from the SRD's text layer, checked against the printed pages.
Missing text (added)
Squeezing (pp. 91–92).
srd:movement-and-positionalready pointed at it.(incl. death saves), Knocking a Creature Out, Temporary HP (pp. 97–99)
Fixed
"later in this chapter") — back to the SRD's
Tested
quicksetup+pytestpass (93), with the other PRs applied too.Side note, not changed: the two Sage Advice quotes (Rolling 1 or 20, Bonus Actions) are
paraphrases of the Compendium rather than quotes. Might be worth a label.
Happy to split this up if it's too big.