Skip to content

Fix OkHttpUtil.newDispatcher javadoc to state the concurrency bounds #8759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Draft

Fix OkHttpUtil.newDispatcher javadoc to state the concurrency bounds #8759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...der/okhttp/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ public static void setPropagateContextForTestingInDispatcher(
OkHttpUtil.propagateContextForTestingInDispatcher = propagateContextForTestingInDispatcher;
}

/** Returns a {@link Dispatcher} using daemon threads, otherwise matching the OkHttp default. */
/**
* Returns a {@link Dispatcher} using daemon threads, with both the maximum number of concurrent
* requests and the maximum size of the backing thread pool bounded to {@code
* max(availableProcessors, 5)}, matching the bound used by {@code JdkHttpSender}.
*/
public static Dispatcher newDispatcher() {
int maxRequests = Math.max(Runtime.getRuntime().availableProcessors(), 5);
Dispatcher dispatcher =
Expand Down
Loading