Fix OkHttpUtil.newDispatcher javadoc to state the concurrency bounds - #8759
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix OkHttpUtil.newDispatcher javadoc to state the concurrency bounds#8759thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8759 +/- ##
=========================================
Coverage 91.29% 91.29%
Complexity 10498 10498
=========================================
Files 1006 1006
Lines 28338 28338
Branches 3581 3581
=========================================
+ Hits 25870 25871 +1
Misses 1675 1675
+ Partials 793 792 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusWaiting on the author · refreshed 2026-09-02 14:35 UTC Move out of draft to request review. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No closing keyword: #8316 also asks for
RejectedExecutionExceptionhandling, which this javadoc-only change does not address, so it should stay open.Description
OkHttpUtil.newDispatcher()says the returnedDispatchermatches the OkHttp default apart from using daemon threads, but that has not been true since Bound OkHttp sender dispatchers and surface rejections #8422 (9dd6c38e0), which changed the code and left the sentence behind.Dispatcherdefaults tomaxRequests = 64and an executor with an unbounded maximum pool size; this method bounds both tomax(availableProcessors, 5).JdkHttpSender.newExecutor(), so the javadoc now names it.maxRequestsPerHostis left out because it is still OkHttp's own default.Testing done
OkHttpUtilTest.newDispatcher_isBounded(), added by Bound OkHttp sender dispatchers and surface rejections #8422, already asserts themax(availableProcessors, 5)bound the new javadoc describes../gradlew :exporters:sender:okhttp:check— 46 tests passed.docs/apidiffs/current_vs_latest/opentelemetry-exporter-sender-okhttp.txtis unchanged (japicmp does not read javadoc text).