Skip to content

fix(flagd): log expected sync-stream recycles at debug, not warning #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 1 commit into from
Jul 30, 2026
+5 −1
Merged

fix(flagd): log expected sync-stream recycles at debug, not warning #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ def _handle_flag_response(

def _handle_rpc_error(self, e: grpc.RpcError) -> bool:
"""Handle a gRPC RpcError. Returns True if the stream loop should stop."""
logger.warning(f"SyncFlags stream error, {e.code()=} {e.details()=}")
if e.code().name in self.config.fatal_status_codes:
logger.error(f"SyncFlags stream fatal error, {e.code()=} {e.details()=}")
self._is_fatal = True
self.active = False
self.emit_provider_error(
Expand All @@ -281,6 +281,10 @@ def _handle_rpc_error(self, e: grpc.RpcError) -> bool:
)
)
return True
# non-fatal errors just reconnect; real loss surfaces as a STALE event
logger.debug(
f"SyncFlags stream error, reconnecting, {e.code()=} {e.details()=}"
)
return False

def listen(self) -> None:
Expand Down
Loading