Skip to content

fix(flagd): log expected sync-stream recycles at debug, not warning - #405

Merged
toddbaert merged 1 commit into
mainfrom
fix/logspam
Jul 30, 2026
Merged

fix(flagd): log expected sync-stream recycles at debug, not warning#405
toddbaert merged 1 commit into
mainfrom
fix/logspam

Conversation

@toddbaert

@toddbaert toddbaert commented Jul 30, 2026

Copy link
Copy Markdown
Member

All our streams use a 10 minute deadline by default - for that reason, many stream "errors" represent expected behavior. The stale -> error transition is really what's a error - so this line should be DEBUG or we get massive logspam (this was unintentionally changed here).

@toddbaert
toddbaert requested review from a team as code owners July 30, 2026 16:19
@github-actions
github-actions Bot requested review from aepfli and federicobond July 30, 2026 16:19
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The gRPC watcher now logs fatal RPC errors at error level and non-fatal errors at debug level with an explicit reconnection message.

Changes

gRPC Error Logging

Layer / File(s) Summary
Classify and log RPC errors
providers/openfeature-provider-flagd/.../grpc_watcher.py
_handle_rpc_error checks fatal status codes before logging, uses error logging for fatal errors, and uses debug logging for non-fatal errors while retaining reconnection behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aepfli

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: lowering expected sync-stream recycle logging from warning to debug.
Description check ✅ Passed The description is directly related to the logging change and explains why the warning should become debug.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (cde03cc) to head (eb40342).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   95.54%   95.55%           
=======================================
  Files          24       24           
  Lines        1033     1034    +1     
=======================================
+ Hits          987      988    +1     
  Misses         46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
toddbaert merged commit 62e251d into main Jul 30, 2026
16 checks passed
@toddbaert
toddbaert deleted the fix/logspam branch July 30, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants