Repository navigation
Conversation
This was referenced Oct 6, 2026
Author
|
@piekstra-dev this is PR 2/2, dependent on #501. Please review the proxy-only range |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit
proxyauth forjtkandcfl: only a URL is required, requests send no Authorization header, and token/keyring requirements are skipped. HTTPS and loopback HTTP endpoints are accepted; remote HTTP is rejected during client construction and init, includingjtk init --no-verifybefore any config is saved.Merge order: 2 of 2 — merge #501 first, then this PR. This branch contains #501's gateway groundwork followed by the proxy-auth commit
e0bde24. Both PRs target upstreammainbecause we cannot create an upstream base branch. Until #501 lands, GitHub's overall diff includes both commits; the proxy-only review range is3d9db37..e0bde24. After #501 merges, rebase this PR onto upstreammainto remove the gateway changes from its diff before merging. Do not merge this PR first.First PR: #501
This replaces the proxy-auth portion of upstream #411. It includes typed shared credential policy, consistent init validation and deferred-token behavior, both runtime paths, and all three auth passes in the integration runbooks. Existing tests remain in their original files to keep the review diff focused.
Validation:
make checkpassed on the complete stack (module tidy, lint, race tests for all three modules, and both CLI builds). Coverage includes omitted Authorization headers, proxy config persistence without credentials, non-loopback HTTP rejection before save, and existing basic/bearer behavior.