Repository navigation
Conversation
This was referenced Oct 6, 2026
Author
|
@piekstra-dev please review this PR first (1/2). This is the isolated gateway portion of #411, rebased onto current upstream and verified with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bearer clients currently hardcode the Atlassian gateway. This change allows
JIRA_GATEWAY_BASE_URL/CFL_GATEWAY_BASE_URL, falling back toATLASSIAN_GATEWAY_BASE_URL, for controlled gateways and local tests. Commands resolve these values and inject them into clients, so construction no longer depends on ambient environment variables. HTTPS and loopback HTTP are accepted; other cleartext endpoints are rejected before sending a bearer token.Merge order: 1 of 2 — merge this PR first. The dependent proxy-auth PR #502 builds on the shared URL validator and unified Confluence client constructor introduced here. After this PR merges, rebase #502 onto upstream
mainso its diff contains only proxy auth before merging it.Second PR: #502
This replaces the gateway portion of #411 with a smaller review scope. Existing basic/bearer defaults and compatibility constructors are retained.
Validation:
make checkpassed on this branch (module tidy, lint, race tests for all three modules, and both CLI builds). Tests cover gateway precedence, explicit injection, independence from ambient environment variables, and rejection of remote HTTP.