Skip to content

Refetch container on newer client revision in object service #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Refetch container on newer client revision in object service #4262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d45e47
Initial plan
Copilot Oct 29, 2026
caece17
Apply remaining changes
Copilot Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/neofs-node/object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,14 @@ func newFSChainForObjects(placementSvc *placement.Service, isLocalPubKey func([]
}
}

// ResetContainer drops cached container, if any, so that next Get fetches it
// from the FS chain.
func (x *fsChainForObjects) ResetContainer(id cid.ID) {
if r, ok := x.Source.(interface{ resetContainer(cid.ID) }); ok {
r.resetContainer(id)
}
}

// InContainerInLastTwoEpochs checks whether given public key belongs to any SN
// from the referenced container either in the current or the previous NeoFS
// epoch.
Expand Down
10 changes: 10 additions & 0 deletions pkg/services/object/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,16 @@ func (s *Server) checkContainerRevision(clientCnrRev uint64, cID cid.ID) error {
return fmt.Errorf("fetching container from FS chain: %w", err)
}

if clientCnrRev > cnr.Revision() {
// server's data may be outdated, try to fetch the newer one
if r, ok := s.fsChain.(interface{ ResetContainer(cid.ID) }); ok {
r.ResetContainer(cID)
if cnr, err = s.fsChain.Get(cID); err != nil {
return fmt.Errorf("fetching container from FS chain: %w", err)
}
}
}

if srvCnrRev := cnr.Revision(); clientCnrRev != srvCnrRev {
return apistatus.NewContainerRevisionMismatch(fmt.Sprintf(
"container revision does not match: requested: %d, server's: %d", clientCnrRev, srvCnrRev))
Expand Down