Repository navigation
Refetch container on newer client revision in object service - #4262
Draft
roman-khimov with Copilot wants to merge 2 commits into
Draft
roman-khimov with Copilot wants to merge 2 commits into
roman-khimov with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: roman-khimov <22092804+roman-khimov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Try to fetch newer container revision in requests
Refetch container on newer client revision in object service
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A gateway can hold a newer container revision than a storage node. Because the node's cache is stale, it rejects the request with
ContainerRevisionMismatch. This change makes the node refetch the container when a request carries a higher revision than the one it has cached.Object service (
pkg/services/object/common.go)checkContainerRevisionresets the cached container and reads it again from the FS chain before comparing.fsChain. TheFSChaininterface and its mocks are unchanged.Node wiring (
cmd/neofs-node/object.go)fsChainForObjects.ResetContainerclears the entry in the container TTL cache (resetContainer). It does nothing if the container source isn't cached.Container service
Abuse risk