Skip to content

sn: support N3 signatures for objects #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carpawell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sn: support N3 signatures for objects #4259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Changelog for NeoFS Node
### Added

### Fixed
- SNs do not support objects signed with N3 scheme via session v2 feature (#4259)

### Changed

Expand Down
24 changes: 14 additions & 10 deletions internal/crypto/object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"errors"
"fmt"

"github.com/nspcc-dev/neo-go/pkg/crypto/hash"
isessions "github.com/nspcc-dev/neofs-node/internal/sessions"
versioncore "github.com/nspcc-dev/neofs-node/pkg/core/version"
neofscrypto "github.com/nspcc-dev/neofs-sdk-go/crypto"
Expand Down Expand Up @@ -73,21 +74,24 @@ func AuthenticateObject(obj object.Object, fsChain HistoricN3ScriptRunner, sToke
return errors.New("different object owner and session issuer")
}
}
var signer = obj.Owner()
if sessionTokenV2 != nil {
// NOTE: update this place for non-ECDSA schemes

@carpawell carpawell Oct 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthulhu-rider do you understand this comment? can it be dropped now? is it about this PR? something else?

@cthulhu-rider cthulhu-rider Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, can be dropped

if ecdsaPub != nil {
nodeUser := user.NewFromECDSAPublicKey(*ecdsaPub)
ok, err := sessionTokenV2.AssertAuthority(nodeUser, resolver)
if err != nil {
return fmt.Errorf("assert session v2 authority: %w", err)
}
if !ok { // same format for all ECDSA schemes
return errors.New("session v2 token is not for object's signer")
}
signer = user.NewFromECDSAPublicKey(*ecdsaPub)
} else {
signer = user.NewFromScriptHash(hash.Hash160(verifScript))
}
ok, err := sessionTokenV2.AssertAuthority(signer, resolver)
if err != nil {
return fmt.Errorf("assert session v2 authority: %w", err)
}
if !ok { // same format for all ECDSA schemes
return errors.New("session v2 token is not for object's signer")
}

k := sha256.Sum256(sessionTokenV2.Marshal())
_, err := sTokenCache.AuthenticateTokenV2(k, func() (sessionv2.Token, error) {
_, err = sTokenCache.AuthenticateTokenV2(k, func() (sessionv2.Token, error) {
if err := AuthenticateTokenV2(sessionTokenV2, fsChain); err != nil {
return sessionv2.Token{}, fmt.Errorf("session token v2: %w", err)
}
Expand All @@ -114,7 +118,7 @@ func AuthenticateObject(obj object.Object, fsChain HistoricN3ScriptRunner, sToke
return errors.New("owner mismatches signature")
}
case neofscrypto.N3:
if err := verifyN3ScriptsAtEpoch(fsChain, obj.CreationEpoch(), obj.Owner().ScriptHash(), invocScript, verifScript, func() [sha256.Size]byte {
if err := verifyN3ScriptsAtEpoch(fsChain, obj.CreationEpoch(), signer.ScriptHash(), invocScript, verifScript, func() [sha256.Size]byte {
return sha256.Sum256(obj.SignedData())
}); err != nil {
return err
Expand Down
Loading