Repository navigation
Conversation
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
October 28, 2026 16:48
carpawell
force-pushed
the
fix/support-n3-signatures-for-objects
branch
2 times, most recently
from
October 28, 2026 16:51
c62dcb6 to
1d8cf33
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
+ Coverage 32.23% 32.24% +0.01%
==========================================
Files 673 673
Lines 41636 41638 +2
==========================================
+ Hits 13423 13428 +5
+ Misses 28213 28210 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
approved these changes
Oct 29, 2026
| var ecdsaPub *ecdsa.PublicKey | ||
| var ( | ||
| ecdsaPub *ecdsa.PublicKey | ||
| signer = obj.Owner() |
Contributor
There was a problem hiding this comment.
i'd declare it right before updated condition below
Member
Author
There was a problem hiding this comment.
dont mind, moved, but both vars are about the same (it is either key, or verif hash, so i wanted them to be together)
carpawell
commented
Oct 29, 2026
| @@ -76,18 +80,20 @@ func AuthenticateObject(obj object.Object, fsChain HistoricN3ScriptRunner, sToke | |||
| if sessionTokenV2 != nil { | |||
| // NOTE: update this place for non-ECDSA schemes | |||
Member
Author
There was a problem hiding this comment.
@cthulhu-rider do you understand this comment? can it be dropped now? is it about this PR? something else?
If an object is signed using N3 scheme with session token, check its verification script as a source of user ID and send this user as a signer to Neo VM. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/support-n3-signatures-for-objects
branch
from
October 29, 2026 12:53
1d8cf33 to
42f9ca4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an object is signed using N3 scheme with session token, check its verification script as a source of user ID and send this user as a signer to Neo VM.