test: expect node:ffi to be enabled by default - #65636
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
test-module-builtin-experimental was added in nodejs#65418 asserting that node:ffi is unavailable without --experimental-ffi, but nodejs#65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: nodejs#65418 Refs: nodejs#65475 Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
added
the
fast-track
nodejs-github-bot
added
needs-ci
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
panva
approved these changes
Aug 29, 2026
mertcanaltin
approved these changes
Aug 29, 2026
panva
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
|
Landed in 2f469df |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65636 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 754 754
Lines 255722 255722
Branches 48314 48310 -4
=======================================
+ Hits 230281 230302 +21
- Misses 16555 16558 +3
+ Partials 8886 8862 -24 🚀 New features to boost your workflow:
|
aduh95
pushed a commit
that referenced
this pull request
Aug 29, 2026
test-module-builtin-experimental was added in #65418 asserting that node:ffi is unavailable without --experimental-ffi, but #65475 had already enabled node:ffi by default in builds with FFI support. The two landed independently and broke main. Expect node:ffi to behave like node:sqlite: available by default with the node: scheme, and gone when opted out with --no-experimental-ffi. Refs: #65418 Refs: #65475 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65636 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-module-builtin-experimental was added in #65418 asserting that
node:ffiis unavailable without--experimental-ffi, but #65475 had already enablednode:ffiby default in builds with FFI support. The two landed independently and every CI run onmainsince 7b0de5e is failing this test (e.g. https://github.com/nodejs/node/actions/runs/33225515486).Expect
node:ffito behave likenode:sqlite: available by default with thenode:scheme, and gone when opted out with--no-experimental-ffi.Since main CI is currently broken, I'd like to fast-track this.