doc: fix broken using link in ffi.md - #65632
Open
soulee-dev wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
trivikr
approved these changes
Aug 29, 2026
Member
|
Can you rebase onto the latest main? #65636 fixed the CI failures. |
The `#sec-using-declarations` fragment does not exist in the explicit resource management proposal, so the link silently resolves to the top of the page. The proposal defines `using` under `#sec-let-and-const-declarations`, and the only `using`-related section ids are static semantics entries. Point the reference at the MDN page for `using` instead, matching the `[`using`]` definition already used in fs.md. Signed-off-by: Soul Lee <alus20x@gmail.com>
soulee-dev
force-pushed
the
doc-fix-ffi-using-link
branch
from
August 29, 2026 13:40
8249db8 to
6fa9f1a
Compare
Contributor
Author
trivikr
approved these changes
Aug 29, 2026
Member
cjihrig
approved these changes
Aug 29, 2026
daeyeon
added
the
author ready
jasnell
approved these changes
Aug 29, 2026
Member
trivikr
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[using]link inffi.mdpoints atproposal-explicit-resource-management/#sec-using-declarations, but thatfragment does not exist, so the link silently resolves to the top of the page.
Point it at the MDN page for
using, whichfs.mdalready uses for the samereference.