feat: support API in direct editing - #4249
Merged
Merged
Conversation
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
4 tasks
4 tasks
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Fetch direct editing capabilities through the dedicated API and clear cached data when the request fails. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use direct-editing capabilities for editor lookup and tighten legacy rich-document MIME type matching. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
marinofaggiana
marked this pull request as draft
August 14, 2026 08:22
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use direct editing editor identifiers to detect supported editors and distinguish Collabora direct editing from legacy rich documents. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Rename rich workspace operations and use direct editing creators for file creation and opening. Handle missing editor URLs as invalid data instead of force-unwrapping them. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Update the richdocuments asset URL API and track the NextcloudKit editors branch. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Route supported editors through the Direct Editing API while preserving legacy Richdocuments fallback for Collabora. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Prefer Direct Editing creators for Collabora and fall back to the legacy Richdocuments API when needed. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use advertised editor names, refresh cached menus when editors change, and match Collabora creators by template identifier. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use the shared EuroOffice identifier when building the context menu. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Add diagram creation and handle RichDocuments commands for image insertion, downloads, printing, renaming, and hyperlinks. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Validate editor URLs and legacy templates before opening created files. Handle Collabora focus, close events, loading failures, and menu sizing. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
4 tasks
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates document editor discovery, creation, and opening to the Nextcloud Direct Editing API while preserving the legacy Richdocuments flow for older Collabora configurations.
What changed
NCViewerDirectEditingwhen therichdocumentsDirect Editing editor is available.NCViewerRichdocumentsflow only when Collabora is not available through Direct Editing.DirectEditingMobileInterfaceandRichDocumentsMobileInterfacein the Direct Editing viewer.NCUtility.Compatibility
richdocuments./apps/richdocuments/endpoints.Dependencies
editorsbranch dependency must be replaced with a released version containing the required APIs.Test plan
NextcloudUnitTests: 45 tests passed in 6 suites.馃 AI (if applicable)