refactor: separate Direct Editing and legacy Richdocuments APIs - #248
Merged
Conversation
Parameterize template requests with editor and creator identifiers. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Parse keyed templates with their MIME type, title, and optional preview fields. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Move direct-editing capability models into a dedicated directory and remove obsolete array conversion helpers. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR generalizes the existing text-specific Direct Editing APIs so they can be used with every editor and creator advertised by the Nextcloud server.
It also clearly separates the core Direct Editing API from the legacy Richdocuments endpoints used by Nextcloud Office/Collabora.
Changes
NextcloudKit+NCTexttoNextcloudKit+DirectEditing.getDirectEditingCapabilitiesopenFileForDirectEditinggetDirectEditingTemplatescreateFileForDirectEditingeditorIdandcreatorIdparameters where required.NKDirectEditingEditorNKDirectEditingCreatorNKDirectEditingTemplatedirectEditingEditorsdirectEditingCreatorsdirectEditingTemplatescreateRichdocumentsEditorURLgetRichdocumentsTemplatescreateRichdocumentsFileFromTemplatecreateRichdocumentsAssetURLAPI compatibility
This PR intentionally renames public APIs and model types. Applications using the previous
text*or Richdocuments method names must migrate to the new names.The underlying legacy Richdocuments endpoints remain unchanged.
Related pull requests
Validation
🤖 AI