Skip to content

fix(new-quotes): git guards never fire in add, get and refuse (@boergeson) #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boergeson wants to merge 2 commits into
base: master
Choose a base branch
from
+42 −3
Open

fix(new-quotes): git guards never fire in add, get and refuse (@boergeson) #8379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0af4a1
fix(new-quotes): check for null git in add, get and refuse
boergeson Aug 29, 2026
a4de031
test(new-quotes): cover missing git
boergeson Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions backend/__tests__/dal/new-quotes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { describe, it, expect, vi } from "vitest";
import { ObjectId } from "mongodb";
import * as NewQuotesDal from "../../src/dal/new-quotes";

vi.mock("simple-git", () => ({
simpleGit: () => {
throw new Error("no repo");
},
}));

describe("NewQuotesDal", () => {
describe("without git", () => {
it("add fails", async () => {
await expect(
NewQuotesDal.add("text", "source", "english", "uid"),
).rejects.toThrow("Git not available.");
});
it("get fails", async () => {
await expect(NewQuotesDal.get("all")).rejects.toThrow(
"Git not available.",
);
});
it("approve fails", async () => {
await expect(
NewQuotesDal.approve(
new ObjectId().toHexString(),
undefined,
undefined,
"name",
),
).rejects.toThrow("Git not available.");
});
it("refuse fails", async () => {
await expect(
NewQuotesDal.refuse(new ObjectId().toHexString()),
).rejects.toThrow("Git not available.");
});
});
});
6 changes: 3 additions & 3 deletions backend/src/dal/new-quotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export async function add(
language: string,
uid: string,
): Promise<AddQuoteReturn | undefined> {
if (git === undefined) throw new MonkeyError(500, "Git not available.");
if (git === null) throw new MonkeyError(500, "Git not available.");
const quote = {
_id: new ObjectId(),
text: text,
Expand Down Expand Up @@ -114,7 +114,7 @@ export async function add(
}

export async function get(language: Language | "all"): Promise<DBNewQuote[]> {
if (git === undefined) throw new MonkeyError(500, "Git not available.");
if (git === null) throw new MonkeyError(500, "Git not available.");
const where: {
approved: boolean;
language?: Language;
Expand Down Expand Up @@ -232,6 +232,6 @@ export async function approve(
}

export async function refuse(quoteId: string): Promise<void> {
if (git === undefined) throw new MonkeyError(500, "Git not available.");
if (git === null) throw new MonkeyError(500, "Git not available.");
await getNewQuoteCollection().deleteOne({ _id: new ObjectId(quoteId) });
}
Loading