fix(new-quotes): git guards never fire in add, get and refuse (@boergeson) - #8379
Open
boergeson wants to merge 2 commits into
Open
fix(new-quotes): git guards never fire in add, get and refuse (@boergeson)#8379boergeson wants to merge 2 commits into
boergeson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tryCatchSyncreturnsdata: nullwhen the callback throws, so the git guards inadd,getandrefusethat compare againstundefinednever fire. Onlyapprovewas updated tonullin #6492. With no quotes repo checked out those three just run as if git was there.Changed the three checks to
=== null. Added a spec that mockssimple-gitto throw, on master add/get/refuse pass through, with this change all four throw the 500.Note the issue describes it the other way round (says approve is the broken one), but
approveis the only one that was right, seepackages/util/src/trycatch.ts.Closes #8364