Skip to content

fix(result-word-highlight): input ending in < shows a broken entity (@boergeson) #8378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boergeson wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −11
Open

fix(result-word-highlight): input ending in < shows a broken entity (@boergeson) #8378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceffce3
fix(result-word-highlight): escape input after slicing
boergeson Aug 29, 2026
94ee049
refactor(test-ui): use escapeHTML for word input
boergeson Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/src/ts/elements/result-word-highlight.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ async function init(): Promise<boolean> {

// Calculate inputWordEl properties relative to inputWordsContainerEl
inputWordEl.style.left = `${wordEl.offsetLeft + PADDING_OFFSET_X - RTL_offset}px`;
inputWordEl.innerHTML = userInputString
.replace(/\t/g, "_")
.replace(/\n/g, "_")
.replace(/</g, "&lt")
.replace(/>/g, "&gt")
.slice(0, wordEl.childElementCount);
inputWordEl.innerHTML = Misc.escapeHTML(
userInputString
.replace(/\t/g, "_")
.replace(/\n/g, "_")
.slice(0, wordEl.childElementCount),
);

inputWordEl.className = "inputWord";
inputWordsContainerEl.append(inputWordEl);
Expand Down
6 changes: 1 addition & 5 deletions frontend/src/ts/test/test-ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,11 +1402,7 @@ async function loadWordsHistory(): Promise<boolean> {
"beforeend",
`<div class="wordInputHighlight withSpeed">
<div class="text">
${input
.replace(/\t/g, "_")
.replace(/\n/g, "_")
.replace(/</g, "&lt")
.replace(/>/g, "&gt")}
${Misc.escapeHTML(input.replace(/\t/g, "_").replace(/\n/g, "_"))}
</div>
<div class="speed">
${isNaN(burst) || burst >= 1000 ? "Infinite" : Format.typingSpeed(burst, { showDecimalPlaces: false })}
Expand Down
Loading