fix(result-word-highlight): input ending in < shows a broken entity (@boergeson) - #8378
Open
boergeson wants to merge 2 commits into
Open
fix(result-word-highlight): input ending in < shows a broken entity (@boergeson)#8378boergeson wants to merge 2 commits into
boergeson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The result word highlight escaped
<and>as</>and then sliced the string to the word length, so an input ending in<got cut in the middle of the entity. Hovering the chart then showedabc&for a typedabc<.Slice first, then run it through
Misc.escapeHTML. Same helper is now used for the words history hover, that one was fine in practice since it isnt sliced, but it had the same handwritten replace chain.Checked with playwright against vite dev, custom text
xyztyped asabc<: master showsabc&in the chart highlight, this branch showsabc<.Closes #8365