Skip to content

fix(test): apply settings changed while the test is restarting (@boergeson) #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boergeson wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

fix(test): apply settings changed while the test is restarting (@boergeson) #8374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions frontend/src/ts/test/test-logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ export async function restart(options = {} as RestartOptions): Promise<void> {

if (isTestRestarting() || isResultCalculating()) {
options.event?.preventDefault();
if (isTestRestarting() && !options.isQuickRestart) {
queuedRestart = { ...options, event: undefined };
}
return;
}
if (isTestActive()) {
Expand Down Expand Up @@ -332,6 +335,7 @@ export async function restart(options = {} as RestartOptions): Promise<void> {

if (!initResult) {
setIsTestRestarting(false);
runQueuedRestart();
return;
}

Expand All @@ -345,6 +349,17 @@ export async function restart(options = {} as RestartOptions): Promise<void> {

await TestUI.fadeInAfterRestart(noAnim);
setIsTestRestarting(false);
runQueuedRestart();
}

let queuedRestart: RestartOptions | null = null;

// config changed while a restart was running, run again so the new settings apply
function runQueuedRestart(): void {
if (queuedRestart === null) return;
const options = queuedRestart;
queuedRestart = null;
void restart(options);
}

let lastInitError: Error | null = null;
Expand Down
Loading