Skip to content

fix(test): apply settings changed while the test is restarting (@boergeson) - #8374

Open
boergeson wants to merge 1 commit into
monkeytypegame:masterfrom
boergeson:fix/queue-restart-while-restarting
Open

fix(test): apply settings changed while the test is restarting (@boergeson)#8374
boergeson wants to merge 1 commit into
monkeytypegame:masterfrom
boergeson:fix/queue-restart-while-restarting

Conversation

@boergeson

Copy link
Copy Markdown
Contributor

Description

restart() returns early when a restart is already running. If you change the mode (or any other setting that restarts the test) while the previous restart is fading in, the new value ends up in the config but the test on screen is still the old one. Thats what happens in #8333 when going time -> words -> quote quickly.

Now a restart that comes in while another one is running is queued and run again once the first one is done, so the latest settings always end up on screen. Quick restarts (tab/esc mashing) are still dropped like before.

Reproduced with playwright by clicking words and then quote with a 130 to 250ms gap between the clicks. Before: config says quote, 25 plain words on screen. After: a quote every time.

Checks

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #8333

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching between test modes doesn't always restart the test with the new mode

2 participants