fix(test): apply settings changed while the test is restarting (@boergeson) - #8374
Open
boergeson wants to merge 1 commit into
Open
fix(test): apply settings changed while the test is restarting (@boergeson)#8374boergeson wants to merge 1 commit into
boergeson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
restart()returns early when a restart is already running. If you change the mode (or any other setting that restarts the test) while the previous restart is fading in, the new value ends up in the config but the test on screen is still the old one. Thats what happens in #8333 when going time -> words -> quote quickly.Now a restart that comes in while another one is running is queued and run again once the first one is done, so the latest settings always end up on screen. Quick restarts (tab/esc mashing) are still dropped like before.
Reproduced with playwright by clicking
wordsand thenquotewith a 130 to 250ms gap between the clicks. Before: config says quote, 25 plain words on screen. After: a quote every time.Checks
Closes #8333