Skip to content

PYTHON-6164 Exclude the drivers-evergreen-tools submodule from linting #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Oct 15, 2026
Merged

PYTHON-6164 Exclude the drivers-evergreen-tools submodule from linting #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
exclude: ^drivers-evergreen-tools/

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
Expand Down
8 changes: 7 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ warn_unused_ignores = false
disable_error_code = ["unused-coroutine", "no-redef"]

[tool.ruff]
target-version = "py39"
line-length = 100
extend-exclude = ["drivers-evergreen-tools"]

[tool.ruff.lint]
select = [
Expand Down Expand Up @@ -241,6 +241,12 @@ ignore = [
"SIM117", # Use a single `with` statement with multiple contexts instead of nested `with` statements
"UP045", # Use `X | Y` for union annotation (Enable when we drop 3.9 support)
"PLC0415", # `import` should be at the top-level of a file
"UP035", # Deprecated import (e.g. `typing.Callable` instead of `collections.abc.Callable`)
"UP041", # `asyncio.TimeoutError` is an alias of `TimeoutError` on 3.11+
"ASYNC109", # Async function with a `timeout` parameter (CSOT timeouts are not `asyncio.timeout`)
"UP042", # `str, Enum` should be `StrEnum` (changes `__str__` semantics)
"UP017", # `timezone.utc` preferred over `datetime.UTC` (keep existing style)
"B905", # `zip()` without an explicit `strict=` parameter
Comment on lines +244 to +249

@NoahStapp NoahStapp Oct 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to fix these in a follow-up ticket, or just intentionally permanently ignoring them?

@blink1073 blink1073 Oct 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created PYTHON-6177

]
unfixable = [
"RUF100", # Unused noqa
Expand Down
Loading