Repository navigation
PYTHON-6164 Exclude the drivers-evergreen-tools submodule from linting - #3126
Merged
Merged
Conversation
…ruff target-version
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Ruff’s target-version configuration must be corrected before approval.
0 open findings
What changed in this PR
This PR excludes the drivers-evergreen-tools submodule from linting and updates Ruff configuration.
Changes:
- Excludes the submodule from Ruff and pre-commit.
- Revises Ruff target-version and rule-ignore settings.
| File | Description |
|---|---|
pyproject.toml |
Updates Ruff exclusions and lint configuration. |
.pre-commit-config.yaml |
Excludes the submodule from pre-commit hooks. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NoahStapp
requested changes
Oct 15, 2026
Comment on lines
+244
to
+249
| "UP035", # Deprecated import (e.g. `typing.Callable` instead of `collections.abc.Callable`) | ||
| "UP041", # `asyncio.TimeoutError` is an alias of `TimeoutError` on 3.11+ | ||
| "ASYNC109", # Async function with a `timeout` parameter (CSOT timeouts are not `asyncio.timeout`) | ||
| "UP042", # `str, Enum` should be `StrEnum` (changes `__str__` semantics) | ||
| "UP017", # `timezone.utc` preferred over `datetime.UTC` (keep existing style) | ||
| "B905", # `zip()` without an explicit `strict=` parameter |
Contributor
There was a problem hiding this comment.
Are we planning to fix these in a follow-up ticket, or just intentionally permanently ignoring them?
NoahStapp
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6164
Changes in this PR
Lint runs no longer scan the drivers-evergreen-tools submodule.
Test Plan
No unit tests (config-only change). Validated with
ruff checkandruff format --check(a scratch file inside the submodule is invisible to both),just lint,just lint-manual, andjust typing.Checklist
Checklist for Author
Checklist for Reviewer