Skip to content

chore(proxy-support): remove linux test skip, update linux electron sandbox COMPASS-9232 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LuciaHarcekova merged 8 commits into from
Oct 8, 2026
Merged

chore(proxy-support): remove linux test skip, update linux electron sandbox COMPASS-9232 #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6923881
fix(mongodb-constants): update $geoNear template COMPASS-6532
LuciaHarcekova Sep 11, 2026
c40f99d
Update packages/mongodb-constants/src/stage-operators.ts
LuciaHarcekova Sep 11, 2026
9ac8714
docs: add " let option" decription for near in $geoNear
LuciaHarcekova Sep 11, 2026
81b4e7c
Testing uncommented process.platform === 'win32' || process.platform …
LuciaHarcekova Oct 6, 2026
6f640c6
Merge remote-tracking branch 'origin/main' into COMPASS-9232-test-fai…
LuciaHarcekova Oct 6, 2026
d9bb9d6
add skip for windows condition proxy options unit tests
LuciaHarcekova Oct 6, 2026
c75735c
Added a Linux-only step to check-test.yaml that sets chrome-sandbox t…
LuciaHarcekova Oct 7, 2026
ea28038
remove TODO comment after fix implemented
LuciaHarcekova Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/check-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ jobs:
git checkout -- packages/saslprep/src/code-points-data.ts
shell: bash

- name: Configure Electron sandbox
if: ${{ runner.os == 'Linux' }}
run: |
sudo chown root:root node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 node_modules/electron/dist/chrome-sandbox

- name: Info
run: |
LERNA_VERSION=$(npm ls lerna --json | jq -r .dependencies.lerna.version)
Expand Down
7 changes: 1 addition & 6 deletions packages/devtools-proxy-support/src/proxy-options.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,7 @@ describe('proxy options handling', function () {
let setup: HTTPServerProxyTestSetup;

before(async function () {
// TODO: COMPASS-9232 reenable the test on Linux and, ideally, on Windows, after
// investigating the failures.
if (
(process.platform === 'win32' || process.platform === 'linux') &&
process.env.CI
) {
if (process.platform === 'win32' && process.env.CI) {

@Anemy Anemy Oct 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is windows something we can easily remove the skip for as well?

return this.skip();
}
setup = new HTTPServerProxyTestSetup();
Expand Down
Loading