fix(filesystem): reject Windows paths on POSIX - #4704
Open
CryoThrust wants to merge 1 commit into
Open
Conversation
Author
|
The POSIX drive-letter validation change is isolated to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4686.
On POSIX hosts, a Windows drive path such as
C:\\Users\\me\\notes\\file.mdwas treated as a relative filename inside the allowed directory. The operation could report success while writing to the wrong path.Reject drive-letter forms before relative path resolution when running on POSIX. Windows behavior and normal POSIX paths are unchanged. A regression test covers the rejection.
Verification
git diff --checkpasses.simdjsondylib is missing.